Changeset 53058 in webkit

Timestamp:

Jan 10, 2010 7:41:02 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-01-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

http/tests/messaging/cross-domain-message-event-dispatch.html failed on Gtk Linux 64-Bit Debug Bot
​https://bugs.webkit.org/show_bug.cgi?id=33458

Fix flakey test. If the machine is very slow, then more than 10ms
might have elapsed between registering the timeout and calling
postMessage. We can't be sure which order they will be called in.
Re-ordering the call guarantees the arrival order, even if it reduces
our coverage slightly.

• http/tests/messaging/cross-domain-message-event-dispatch.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/messaging/cross-domain-message-event-dispatch.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-01-10  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        http/tests/messaging/cross-domain-message-event-dispatch.html failed on Gtk Linux 64-Bit Debug Bot
+        https://bugs.webkit.org/show_bug.cgi?id=33458
+
+        Fix flakey test.  If the machine is very slow, then more than 10ms
+        might have elapsed between registering the timeout and calling
+        postMessage.  We can't be sure which order they will be called in.
+        Re-ordering the call guarantees the arrival order, even if it reduces
+        our coverage slightly.
+
+        * http/tests/messaging/cross-domain-message-event-dispatch.html:
+
 2010-01-10  Adam Barth  <abarth@webkit.org>
 

trunk/LayoutTests/http/tests/messaging/cross-domain-message-event-dispatch.html

@@ -23 +23 @@
 
     // The setTimeout handlers will get called after the
-    // event listeners, because setTimeout has a minimum wait time
-    // of 10ms while postMessage has no minimum wait time.
+    // event listeners.
     postMessage("Message1", "*");
+    postMessage("Message2", "*");
+    postMessage("Message3", "*");
     setTimeout("log('setTimeout1')", 0);
-    postMessage("Message2", "*");
     setTimeout("log('setTimeout2')", 0);
-    postMessage("Message3", "*");
     setTimeout(done, 0);
     log("Events queued");