Changeset 53063 in webkit


Ignore:
Timestamp:
Jan 10, 2010 9:11:21 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-01-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Let webkit-patch work with options in $EDITOR
​https://bugs.webkit.org/show_bug.cgi?id=33414

The $EDITOR evironment variable might have command line options like
bbedit -w. This patch lets us run those $EDITORs.

  • Scripts/webkitpy/user.py:
Location:
trunk/WebKitTools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r53060 r53063  
     12010-01-10  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Let webkit-patch work with options in $EDITOR
     6        https://bugs.webkit.org/show_bug.cgi?id=33414
     7
     8        The $EDITOR evironment variable might have command line options like
     9        bbedit -w.  This patch lets us run those $EDITORs.
     10
     11        * Scripts/webkitpy/user.py:
     12
    1132010-01-10  Robert Hogan  <robert@roberthogan.net>
    214

  • trunk/WebKitTools/Scripts/webkitpy/user.py

    r52715 r53063  
    2828
    2929import os
     30import shlex
    3031import subprocess
    3132import webbrowser
    … …  
    3738    def edit(self, files):
    3839        editor = os.environ.get("EDITOR") or "vi"
    39         subprocess.call([editor] + files)
     40        args = shlex.split(editor)
     41        subprocess.call(args + files)
    4042
    4143    def page(self, message):
Note: See TracChangeset for help on using the changeset viewer.