Changeset 53134 in webkit


Ignore:
Timestamp:
Jan 12, 2010 4:31:44 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-01-12 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

AssignToCommitter does not need to fetch bugs twice
https://bugs.webkit.org/show_bug.cgi?id=33530

This is a no-brainer patch now that we've added Bug.reviewed_patches

  • Scripts/webkitpy/commands/upload.py:
Location:
trunk/WebKitTools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r53133 r53134  
     12010-01-12  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        AssignToCommitter does not need to fetch bugs twice
     6        https://bugs.webkit.org/show_bug.cgi?id=33530
     7
     8        This is a no-brainer patch now that we've added Bug.reviewed_patches
     9
     10        * Scripts/webkitpy/commands/upload.py:
     11
    1122010-01-12  Eric Seidel  <eric@webkit.org>
    213
  • trunk/WebKitTools/Scripts/webkitpy/commands/upload.py

    r53133 r53134  
    6868            return
    6969
    70         # FIXME: This should call a reviewed_patches() method on bug instead of re-fetching.
    71         reviewed_patches = self.tool.bugs.fetch_bug(bug_id).reviewed_patches()
     70        reviewed_patches = bug.reviewed_patches()
    7271        if not reviewed_patches:
    7372            log("Bug %s has no non-obsolete patches, ignoring." % bug_id)
Note: See TracChangeset for help on using the changeset viewer.