Changeset 53140 in webkit

Timestamp:

Jan 12, 2010 6:37:19 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-12 Petri Latvala <​petri.latvala@nomovok.com>

Reviewed by Antti Koivisto.

fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html failed on buildbot
​https://bugs.webkit.org/show_bug.cgi?id=33465

A touchmove event is not dispatched if none of the touch points actually moved.
Changed the test to use touchstart instead.

• fast/events/touch/touch-coords-in-zoom-and-scroll.html:
• platform/qt/Skipped:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/touch/touch-coords-in-zoom-and-scroll.html (modified) (5 diffs)
• platform/qt/Skipped (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-01-12  Petri Latvala  <petri.latvala@nomovok.com>
+
+        Reviewed by Antti Koivisto.
+
+        fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html failed on buildbot
+        https://bugs.webkit.org/show_bug.cgi?id=33465
+
+        A touchmove event is not dispatched if none of the touch points actually moved.
+        Changed the test to use touchstart instead.
+
+        * fast/events/touch/touch-coords-in-zoom-and-scroll.html:
+        * platform/qt/Skipped:
+
 2010-01-12  Eric Seidel  <eric@webkit.org>
 

trunk/LayoutTests/fast/events/touch/touch-coords-in-zoom-and-scroll.html

@@ -16 +16 @@
     var event;
 
-    function sendTouchMove()
+    function sendTouchStart(x, y)
     {
         if (window.eventSender) {
-            eventSender.touchMove();
+            eventSender.clearTouchPoints();
+            eventSender.addTouchPoint(x, y);
+            eventSender.touchStart();
         }
     }
@@ -58 +60 @@
     }
 
-    window.addEventListener("touchmove", base, false);
-
-    if (window.eventSender) {
-        eventSender.addTouchPoint(100, 100);
-        eventSender.touchStart();
-    }
+    window.addEventListener("touchstart", base, false);
     
-    sendTouchMove();
-    window.removeEventListener("touchmove", base, false);
+    sendTouchStart(100, 100);
+    window.removeEventListener("touchstart", base, false);
     
     // Just zoomed.
@@ -78 +75 @@
         shouldBe("event.touches[0].pageY", "83");
     }
-    window.addEventListener("touchmove", justZoomed, false);
+    window.addEventListener("touchstart", justZoomed, false);
     zoomPageIn();
-    sendTouchMove();
+    sendTouchStart(100, 100);
     zoomPageOut();
-    window.removeEventListener("touchmove", justZoomed, false);
+    window.removeEventListener("touchstart", justZoomed, false);
 
     // Just scrolled.
@@ -94 +91 @@
         shouldBe("event.touches[0].pageY", "150");
     }
-    window.addEventListener("touchmove", justScrolled, false);
+    window.addEventListener("touchstart", justScrolled, false);
     scrollPage(50, 50);
-    sendTouchMove();
+    sendTouchStart(100, 100);
     scrollPage(0, 0);
-    window.removeEventListener("touchmove", justScrolled, false);
+    window.removeEventListener("touchstart", justScrolled, false);
 
     // Zoomed and scrolled.
@@ -110 +107 @@
         shouldBe("event.touches[0].pageY", "133");
     }
-    window.addEventListener("touchmove", zoomedAndScrolled, false);
+    window.addEventListener("touchstart", zoomedAndScrolled, false);
     zoomPageIn();
     scrollPage(50, 50);
-    sendTouchMove();
+    sendTouchStart(100, 100);
     zoomPageOut();
     scrollPage(0, 0);
-    window.removeEventListener("touchmove", zoomedAndScrolled, false);
+    window.removeEventListener("touchstart", zoomedAndScrolled, false);
 
     if (window.eventSender) {

trunk/LayoutTests/platform/qt/Skipped

@@ -5090 +5090 @@
 fast/forms/slider-zoomed.html
 fast/forms/slider-mouse-events.html
-
-# https://bugs.webkit.org/show_bug.cgi?id=33465
-fast/events/touch/touch-coords-in-zoom-and-scroll.html