Changeset 53188 in webkit

Timestamp:

Jan 13, 2010 8:31:49 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-13 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Timeline panel scrolling speed can be increased.
​https://bugs.webkit.org/show_bug.cgi?id=33579

• inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._scheduleRefresh): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TimelinePanel.js (modified) (6 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        WebInspector: Timeline panel scrolling speed can be increased.
+        https://bugs.webkit.org/show_bug.cgi?id=33579
+
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel):
+        (WebInspector.TimelinePanel.prototype._scheduleRefresh):
+        (WebInspector.TimelinePanel.prototype._refresh):
+        (WebInspector.TimelinePanel.prototype._refreshRecords):
+
 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
 

trunk/WebCore/inspector/front-end/TimelinePanel.js

@@ -35 +35 @@
 
     this._overviewPane = new WebInspector.TimelineOverviewPane(this.categories);
-    this._overviewPane.addEventListener("window changed", this._scheduleRefresh, this);
+    this._overviewPane.addEventListener("window changed", this._windowChanged, this);
     this._overviewPane.addEventListener("filter changed", this._refresh, this);
     this.element.appendChild(this._overviewPane.element);
@@ -81 +81 @@
     this._sendRequestRecords = {};
     this._calculator = new WebInspector.TimelineCalculator();
+    this._boundariesAreValid = true;
 }
 
@@ -292 +293 @@
     },
 
-    _scheduleRefresh: function(immediate)
-    {
+    _windowChanged: function()
+    {
+        this._scheduleRefresh();
+    },
+  
+    _scheduleRefresh: function(preserveBoundaries)
+    {
+        this._boundariesAreValid &= preserveBoundaries;
         if (this._needsRefresh)
             return;
@@ -299 +306 @@
 
         if (this.visible && !("_refreshTimeout" in this))
-            this._refreshTimeout = setTimeout(this._refresh.bind(this), immediate ? 0 : 100);
+            this._refreshTimeout = setTimeout(this._refresh.bind(this), preserveBoundaries ? 0 : 100);
     },
 
@@ -309 +316 @@
             delete this._refreshTimeout;
         }
-        this._overviewPane.update(this._records);
-        this._refreshRecords();
-    },
-
-    _refreshRecords: function()
-    {
-        this._calculator.windowLeft = this._overviewPane.windowLeft;
-        this._calculator.windowRight = this._overviewPane.windowRight;
-        this._calculator.reset();
-
-        for (var i = 0; i < this._records.length; ++i)
-            this._calculator.updateBoundaries(this._records[i]);
+      
+        if (!this._boundariesAreValid)
+            this._overviewPane.update(this._records);
+        this._refreshRecords(!this._boundariesAreValid);
+        this._boundariesAreValid = true;
+    },
+
+    _refreshRecords: function(updateBoundaries)
+    {
+        if (updateBoundaries) {
+            this._calculator.windowLeft = this._overviewPane.windowLeft;
+            this._calculator.windowRight = this._overviewPane.windowRight;
+            this._calculator.reset();
+
+            for (var i = 0; i < this._records.length; ++i)
+                this._calculator.updateBoundaries(this._records[i]);
+        }
 
         var recordsInWindow = [];
@@ -392 +404 @@
         // Reserve some room for expand / collapse controls to the left for records that start at 0ms.
         var timelinePaddingLeft = this._calculator.windowLeft === 0 ? expandOffset : 0;
-        this._timelineGrid.updateDividers(true, this._calculator, timelinePaddingLeft);
+        if (updateBoundaries)
+            this._timelineGrid.updateDividers(true, this._calculator, timelinePaddingLeft);
         this._adjustScrollPosition((recordsInWindow.length + 1) * rowHeight);
     },