Changeset 53228 in webkit

Timestamp:

Jan 13, 2010 6:57:19 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix CloseBugForLandDiff unittest to actually run
​https://bugs.webkit.org/show_bug.cgi?id=33640

• Scripts/webkitpy/mock_bugzillatool.py:
• Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/mock_bugzillatool.py (modified) (1 diff)
• Scripts/webkitpy/steps/closebugforlanddiff_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-13  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Fix CloseBugForLandDiff unittest to actually run
+        https://bugs.webkit.org/show_bug.cgi?id=33640
+
+        * Scripts/webkitpy/mock_bugzillatool.py:
+        * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
+
 2010-01-12  Jon Honeycutt  <jhoneycutt@apple.com>
 

trunk/WebKitTools/Scripts/webkitpy/mock_bugzillatool.py

@@ -184 +184 @@
         return "DiffForRevision%s\nhttp://bugs.webkit.org/show_bug.cgi?id=12345" % revision
 
+    def svn_revision_from_commit_text(self, commit_text):
+        return "49824"
+
     def modified_changelogs(self):
         # Ideally we'd return something more interesting here.

trunk/WebKitTools/Scripts/webkitpy/steps/closebugforlanddiff_unittest.py

@@ -34 +34 @@
 from webkitpy.outputcapture import OutputCapture
 
-class UpdateChangeLogsWithReviewerTest(unittest.TestCase):
+class CloseBugForLandDiffTest(unittest.TestCase):
     def test_empty_state(self):
         capture = OutputCapture()
         step = CloseBugForLandDiff(MockBugzillaTool(), Mock())
-        capture.assert_outputs(self, step.run, [{}])
+        expected_stderr = "Committed r49824: <http://trac.webkit.org/changeset/49824>\nNo bug id provided.\n"
+        capture.assert_outputs(self, step.run, [{"commit_text" : "Mock commit text"}], expected_stderr=expected_stderr)