Changeset 53327 in webkit


Ignore:
Timestamp:
Jan 15, 2010 1:43:15 AM (14 years ago)
Author:
Girish Ramakrishnan
Message:

[Qt/Win] Flash in QGraphicsWebView does not process hover correctly.

Reviewed by Simon Hausmann.

Mouse hover does not work as expected with the flash in some sites.

The problem appears to be that Flash queries NPNVnetscapeWindow on every
mouse hover. I do not how flash uses this value but returning 0 when flash
is in windowless mode solves the problem (When using QGraphicsWebView we
inject wmode opaque, thereby putting the plugin in windowless mode).

https://bugs.webkit.org/show_bug.cgi?id=33591

Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r53326 r53327  
     12010-01-13  Girish Ramakrishnan  <girish@forwardbias.in>
     2
     3        Reviewed by Simon Hausmann.
     4
     5        [Qt/Win] Flash in QGraphicsWebView does not process hover correctly.
     6       
     7        https://bugs.webkit.org/show_bug.cgi?id=33591
     8       
     9        Mouse hover does not work as expected with the flash in some sites.
     10        - http://www.bbc.co.uk/ Hover over the map
     11        - http://www.barbie.com/ Hover over the menu items (Games, Videos)
     12        The problem appears to be that Flash queries NPNVnetscapeWindow on every
     13        mouse hover. I do not how flash uses this value but returning 0 when flash
     14        is in windowless mode solves the problem (When using QGraphicsWebView we
     15        inject wmode opaque, thereby putting the plugin in windowless mode).
     16
     17        * plugins/win/PluginViewWin.cpp:
     18        (windowHandleForPageClient):
     19
    1202010-01-15  Zoltan Horvath  <zoltan@webkit.org>
    221
  • trunk/WebCore/plugins/win/PluginViewWin.cpp

    r52995 r53327  
    9999    if (!client)
    100100        return 0;
    101     return client->ownerWidget()->winId();
     101    if (QWidget* pluginParent = qobject_cast<QWidget*>(client->pluginParent()))
     102        return pluginParent->winId();
     103    return 0;
    102104#elif PLATFORM(WX)
    103105    if (!client)
Note: See TracChangeset for help on using the changeset viewer.