Changeset 53333 in webkit


Ignore:
Timestamp:
Jan 15, 2010 9:46:01 AM (14 years ago)
Author:
ojan@chromium.org
Message:

2010-01-14 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

animations/combo-transform-translate+scale.html failed on Snow Leopard Debug Bot
​https://bugs.webkit.org/show_bug.cgi?id=33461

Make test half as long. Remove a setTimeout and tweak tolerances to
reduce flakiness.

  • animations/combo-transform-translate+scale.html:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r53324 r53333  
     12010-01-14  Ojan Vafai  <ojan@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        animations/combo-transform-translate+scale.html failed on Snow Leopard Debug Bot
     6        https://bugs.webkit.org/show_bug.cgi?id=33461
     7
     8        Make test half as long. Remove a setTimeout and tweak tolerances to
     9        reduce flakiness.
     10
     11        * animations/combo-transform-translate+scale.html:
     12
    1132010-01-14  Darin Fisher  <darin@chromium.org>
    214

  • trunk/LayoutTests/animations/combo-transform-translate+scale-expected.txt

    r39922 r53333  
    1 This test performs an animation of the translate() and scale() operators. It animates over 2 seconds. At 0.5 and 1 second it takes a snapshot and expects the result to be within range.
     1This test performs an animation of the translate() and scale() operators. It animates over 1 seconds. At 0.25 and 0.5 seconds it takes a snapshot and expects the result to be within range.
    22PASS

  • trunk/LayoutTests/animations/combo-transform-translate+scale.html

    r52843 r53333  
    1111      width: 100px;
    1212      background-color: blue;
    13       -webkit-animation-duration: 2s;
     13      -webkit-animation-duration: 1s;
    1414      -webkit-animation-timing-function: linear;
    1515      -webkit-animation-name: "anim";
    … …  
    2626    }
    2727   
    28     result = "PASS";
     28    result = "";
    2929
    3030    const expected =  [ [ 1.25,0,0,1.75,25,50 ],
    3131                        [ 1.5,0,0,2.5,50,100 ] ];
    32     const tolerance = [ 0.2,0.2,0.2,0.2,5,10 ];
     32    const tolerance = [ 0.2,0.2,0.2,0.3,5,15 ];
    3333    const prop = [ "a", "b", "c", "d", "e", "f" ];
    3434   
    … …  
    3939    }
    4040   
     41    var numSnapshots = 0;
     42   
    4143    function snapshot(which)
    4244    {
    43         if (result != "PASS")
    44             return;
     45        var t = new WebKitCSSMatrix(window.getComputedStyle(document.getElementById('box')).webkitTransform);
     46        for (i = 0; i < 6; ++i) {
     47            if (!isEqual(t[prop[i]], expected[which][i], tolerance[i]))
     48                result += "FAIL('"+prop[i]+"' was:"+t[prop[i]]+", expected:"+expected[which][i]+")";
     49        }
    4550       
    46         var t = new WebKitCSSMatrix(window.getComputedStyle(document.getElementById('box')).webkitTransform);
    47         for (i = 0; i < 6; ++i)
    48             if (!isEqual(t[prop[i]], expected[which][i], tolerance[i])) {
    49                 result = "FAIL('"+prop[i]+"' was:"+t[prop[i]]+", expected:"+expected[which][i]+")";
    50                 return;
    51             }
     51        numSnapshots++;
     52        if (numSnapshots == 2) {
     53            document.getElementById('result').innerHTML = result || "PASS";
     54            if (window.layoutTestController)
     55                layoutTestController.notifyDone();
     56        }
    5257    }
    5358
    5459    function start()
    5560    {
    56         setTimeout("snapshot(0)", 500);
    57         setTimeout("snapshot(1)", 1000);
    58        
    59         window.setTimeout(function() {
    60             document.getElementById('result').innerHTML = result;
    61             if (window.layoutTestController)
    62                 layoutTestController.notifyDone();
    63         }, 1100);
     61        setTimeout("snapshot(0)", 250);
     62        setTimeout("snapshot(1)", 500);
    6463    }
    6564   
    … …  
    6968</head>
    7069<body>
    71 This test performs an animation of the translate() and scale() operators. It animates over 2 seconds.
    72 At 0.5 and 1 second it takes a snapshot and expects the result to be within range.
     70This test performs an animation of the translate() and scale() operators. It animates over 1 seconds.
     71At 0.25 and 0.5 seconds it takes a snapshot and expects the result to be within range.
    7372<div id="box">
    7473</div>
Note: See TracChangeset for help on using the changeset viewer.