Changeset 53368 in webkit


Ignore:
Timestamp:
Jan 16, 2010 5:42:36 PM (14 years ago)
Author:
jhoneycutt@apple.com
Message:

get_accParent should try to retrieve parent AccessibilityObject, before
calling upon window

https://bugs.webkit.org/show_bug.cgi?id=22893

Reviewed by Darin Adler.

WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::get_accParent):
If the object has a parent object, return it. If not, return the
accessible for the WebView window.

WebKitTools:

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::parentElement):
Get the object's parent. Query it for IAccessible, and return it.

LayoutTests:

  • platform/win/accessibility/parent-element-expected.txt: Added.
  • platform/win/accessibility/parent-element.html: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r53364 r53368  
     12010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
     2
     3        get_accParent should try to retrieve parent AccessibilityObject, before
     4        calling upon window
     5
     6        https://bugs.webkit.org/show_bug.cgi?id=22893
     7
     8        Reviewed by Darin Adler.
     9
     10        * platform/win/accessibility/parent-element-expected.txt: Added.
     11        * platform/win/accessibility/parent-element.html: Added.
     12
    1132010-01-16  Darin Adler  <darin@apple.com>
    214
  • trunk/WebKit/win/AccessibleBase.cpp

    r53220 r53368  
    107107    *parent = 0;
    108108
    109     if (!m_object || !m_object->topDocumentFrameView())
     109    if (!m_object)
     110        return E_FAIL;
     111
     112    AccessibilityObject* parentObject = m_object->parentObjectUnignored();
     113    if (parentObject) {
     114        *parent = wrapper(parentObject);
     115        (*parent)->AddRef();
     116        return S_OK;
     117    }
     118
     119    if (!m_object->topDocumentFrameView())
    110120        return E_FAIL;
    111121
  • trunk/WebKit/win/ChangeLog

    r53220 r53368  
     12010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
     2
     3        get_accParent should try to retrieve parent AccessibilityObject, before
     4        calling upon window
     5
     6        https://bugs.webkit.org/show_bug.cgi?id=22893
     7
     8        Reviewed by Darin Adler.
     9
     10        * AccessibleBase.cpp:
     11        (AccessibleBase::get_accParent):
     12        If the object has a parent object, return it. If not, return the
     13        accessible for the WebView window.
     14
    1152010-01-12  Jon Honeycutt  <jhoneycutt@apple.com>
    216
  • trunk/WebKitTools/ChangeLog

    r53362 r53368  
     12010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
     2
     3        get_accParent should try to retrieve parent AccessibilityObject, before
     4        calling upon window
     5
     6        https://bugs.webkit.org/show_bug.cgi?id=22893
     7
     8        Reviewed by Darin Adler.
     9
     10        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
     11        (AccessibilityUIElement::parentElement):
     12        Get the object's parent. Query it for IAccessible, and return it.
     13
    1142010-01-16  Dan Bernstein  <mitz@apple.com>
    215
  • trunk/WebKitTools/DumpRenderTree/win/AccessibilityUIElementWin.cpp

    r53220 r53368  
    127127AccessibilityUIElement AccessibilityUIElement::parentElement()
    128128{
    129     return 0;
     129    COMPtr<IDispatch> parent;
     130    m_element->get_accParent(&parent);
     131
     132    COMPtr<IAccessible> parentAccessible(Query, parent);
     133    return parentAccessible;
    130134}
    131135
Note: See TracChangeset for help on using the changeset viewer.