Changeset 53369 in webkit

Timestamp:

Jan 16, 2010 5:42:53 PM (14 years ago)

Author:

jhoneycutt@apple.com

Message:

MSAA: Screen rect for <option> elements is always the zero rect

​https://bugs.webkit.org/show_bug.cgi?id=33758

Reviewed by Oliver Hunt.

WebKit/win:

• AccessibleBase.cpp:

(AccessibleBase::accLocation):
Use elementRect() rather than boundingBoxRect(), which
AccessibilityListBoxOption overrides.

LayoutTests:

• platform/win/accessibility/option-element-position-and-size-expected.txt: Added.
• platform/win/accessibility/option-element-position-and-size.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/win/accessibility/option-element-position-and-size-expected.txt (added)
• LayoutTests/platform/win/accessibility/option-element-position-and-size.html (added)
• WebKit/win/AccessibleBase.cpp (modified) (1 diff)
• WebKit/win/ChangeLog (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
+
+        MSAA: Screen rect for <option> elements is always the zero rect
+
+        https://bugs.webkit.org/show_bug.cgi?id=33758
+
+        Reviewed by Oliver Hunt.
+
+        * platform/win/accessibility/option-element-position-and-size-expected.txt: Added.
+        * platform/win/accessibility/option-element-position-and-size.html: Added.
+
 2010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
 

trunk/WebKit/win/AccessibleBase.cpp

@@ -420 +420 @@
         return E_FAIL;
 
-    IntRect screenRect(childObj->documentFrameView()->contentsToScreen(childObj->boundingBoxRect()));
+    IntRect screenRect(childObj->documentFrameView()->contentsToScreen(childObj->elementRect()));
     *left = screenRect.x();
     *top = screenRect.y();

trunk/WebKit/win/ChangeLog

@@ +1 @@
+2010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
+
+        MSAA: Screen rect for <option> elements is always the zero rect
+
+        https://bugs.webkit.org/show_bug.cgi?id=33758
+
+        Reviewed by Oliver Hunt.
+
+        * AccessibleBase.cpp:
+        (AccessibleBase::accLocation):
+        Use elementRect() rather than boundingBoxRect(), which
+        AccessibilityListBoxOption overrides.
+
 2010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>