Changeset 53378 in webkit

Timestamp:

Jan 17, 2010 4:36:31 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-17 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

style-queue should include instructions for how to file bugs against check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=32345

Added some text to the error message asking folks to file bugs against
false positives.

• Scripts/webkitpy/commands/queues.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/commands/queues.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-17  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        style-queue should include instructions for how to file bugs against check-webkit-style
+        https://bugs.webkit.org/show_bug.cgi?id=32345
+
+        Added some text to the error message asking folks to file bugs against
+        false positives.
+
+        * Scripts/webkitpy/commands/queues.py:
+
 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/commands/queues.py

@@ -287 +287 @@
         if is_svn_apply:
             QueueEngine.exit_after_handled_error(script_error)
-        message = "Attachment %s did not pass %s:\n\n%s" % (state["patch"].id(), cls.name, script_error.message_with_output(output_limit=3*1024))
+        message = "Attachment %s did not pass %s:\n\n%s\n\nIf any of these errors are false positives, please file a bug against check-webkit-style." % (state["patch"].id(), cls.name, script_error.message_with_output(output_limit=3*1024))
         tool.bugs.post_comment_to_bug(state["patch"].bug_id(), message, cc=cls.watchers)
         exit(1)