Changeset 53380 in webkit

Timestamp:

Jan 17, 2010 5:49:39 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

style-queue complains about missing #include of config.h for non-WebCore projects
​https://bugs.webkit.org/show_bug.cgi?id=33170

WebKitAPITests are consumers of the WebKit API and therefore do not
need to follow the same include discipline as the rest of WebKit. This
patch exempts them from the include checks.

• Scripts/webkitpy/style/cpp_style.py:
• Scripts/webkitpy/style/cpp_style_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/cpp_style.py (modified) (1 diff)
• Scripts/webkitpy/style/cpp_style_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-17  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        style-queue complains about missing #include of config.h for non-WebCore projects
+        https://bugs.webkit.org/show_bug.cgi?id=33170
+
+        WebKitAPITests are consumers of the WebKit API and therefore do not
+        need to follow the same include discipline as the rest of WebKit.  This
+        patch exempts them from the include checks.
+
+        * Scripts/webkitpy/style/cpp_style.py:
+        * Scripts/webkitpy/style/cpp_style_unittest.py:
+
 2010-01-17  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/style/cpp_style.py

@@ -2109 +2109 @@
     """
 
+    if filename.find('WebKitTools/WebKitAPITest/') >= 0:
+        # Files in this directory are consumers of the WebKit API and
+        # therefore do not follow the same header including discipline as
+        # WebCore.
+        return
+
     line = clean_lines.lines[line_number]
 

trunk/WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py

@@ -2028 +2028 @@
                                          '')
 
+    def test_webkit_api_test_excluded(self):
+        self.assert_language_rules_check('WebKitTools/WebKitAPITest/Test.h',
+                                         '#include "foo.h"\n',
+                                         '')
+
     def test_check_line_break_after_own_header(self):
         self.assert_language_rules_check('foo.cpp',