Changeset 53389 in webkit

Timestamp:

Jan 17, 2010 8:53:26 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-17 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[Chromium] Remove an old runFileChooser() method.
​https://bugs.webkit.org/show_bug.cgi?id=33778

Chromium code switched to new runFileChooser() introduced by
r53269. The old one is not needed anymore.

• public/WebViewClient.h:
• src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::runOpenPanel):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebViewClient.h (modified) (1 diff)
• src/ChromeClientImpl.cpp (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-01-17  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Shinichiro Hamaji.
+
+        [Chromium] Remove an old runFileChooser() method.
+        https://bugs.webkit.org/show_bug.cgi?id=33778
+        
+        Chromium code switched to new runFileChooser() introduced by
+        r53269. The old one is not needed anymore.
+
+        * public/WebViewClient.h:
+        * src/ChromeClientImpl.cpp:
+        (WebKit::ChromeClientImpl::runOpenPanel):
+
 2010-01-15  Eric Seidel  <eric@webkit.org>
 

trunk/WebKit/chromium/public/WebViewClient.h

@@ -162 +162 @@
     // Dialogs -------------------------------------------------------------
 
-    // Deprecated. Use another runFileChooser() below instead.
-    virtual bool runFileChooser(
-        bool multiSelect, const WebString& title,
-        const WebString& initialValue, WebFileChooserCompletion*) { return false; }
-
     // This method returns immediately after showing the dialog. When the
     // dialog is closed, it should call the WebFileChooserCompletion to

trunk/WebKit/chromium/src/ChromeClientImpl.cpp

@@ -573 +573 @@
         return;
 
-    // Choosing with new function failed, so fallback to old function.
-    if (client->runFileChooser(params.multiSelect,
-                               params.title,
-                               params.initialValue,
-                               chooserCompletion))
-        return;
-
-    // Choosing with the old function failed, so do callback with an empty list.
+    // Choosing failed, so do callback with an empty list.
     chooserCompletion->didChooseFile(WebVector<WebString>());
 }