Changeset 53414 in webkit
- Timestamp:
- Jan 18, 2010 10:36:26 AM (14 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r53408 r53414 1 2010-01-18 Adam Barth <abarth@webkit.org> 2 3 Reviewed by Adam Roben. 4 5 Rename patches-to-commit to patches-in-commit-queue 6 https://bugs.webkit.org/show_bug.cgi?id=33789 7 8 The command really lists the patches in the commit-queue not all the 9 patches that are pending-commit (as the FIXME commands). 10 11 * Scripts/webkitpy/commands/queries.py: 12 * Scripts/webkitpy/commands/queries_unittest.py: 13 1 14 2010-01-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> 2 15 -
trunk/WebKitTools/Scripts/webkitpy/commands/queries.py
r53298 r53414 49 49 50 50 51 class Patches ToCommit(AbstractDeclarativeCommand):52 name = "patches- to-commit"51 class PatchesInCommitQueue(AbstractDeclarativeCommand): 52 name = "patches-in-commit-queue" 53 53 help_text = "List patches in the commit-queue" 54 54 55 55 def execute(self, options, args, tool): 56 # FIXME: This command is poorly named. It's fetching the commit-queue list here. The name implies it's fetching pending-commit (all r+'d patches).57 56 patches = tool.bugs.queries.fetch_patches_from_commit_queue() 58 57 log("Patches in commit queue:") -
trunk/WebKitTools/Scripts/webkitpy/commands/queries_unittest.py
r53298 r53414 40 40 self.assert_execute_outputs(BugsToCommit(), None, "42\n77\n", expected_stderr) 41 41 42 def test_patches_ to_commit(self):42 def test_patches_in_commit_queue(self): 43 43 expected_stdout = "http://example.com/197\nhttp://example.com/103\n" 44 44 expected_stderr = "Warning, attachment 128 on bug 42 has invalid committer (non-committer@example.com)\nPatches in commit queue:\n" 45 self.assert_execute_outputs(Patches ToCommit(), None, expected_stdout, expected_stderr)45 self.assert_execute_outputs(PatchesInCommitQueue(), None, expected_stdout, expected_stderr) 46 46 47 47 def test_patches_to_commit_queue(self):
Note: See TracChangeset
for help on using the changeset viewer.