Changeset 53466 in webkit

Timestamp:

Jan 19, 2010 6:04:21 AM (14 years ago)

Author:

hamaji@chromium.org

Message:

2010-01-19 MORITA Hajime <​morrita@gmail.com>

Reviewed by Shinichiro Hamaji.

[Chromium] layout_test on linux fails on doubleclick-beside-cr-span.html

Place larger margins before clicking position to grab certain words
instead of clicking blank, whitespaces or tabs before that words.
Note that widths of rendered tab characters are hard to predict,
So such margins are particularly helpful with them.

​https://bugs.webkit.org/show_bug.cgi?id=33769

• editing/selection/doubleclick-beside-cr-span.html: Fix to compute click position using actual character width.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• editing/selection/doubleclick-beside-cr-span.html (modified) (6 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-01-19  MORITA Hajime  <morrita@gmail.com>
+
+        Reviewed by Shinichiro Hamaji.
+
+        [Chromium] layout_test on linux fails on doubleclick-beside-cr-span.html
+        
+        Place larger margins before clicking position to grab certain words
+        instead of clicking blank, whitespaces or tabs before that words. 
+        Note that widths of rendered tab characters are hard to predict,
+        So such margins are particularly helpful with them.
+        
+        https://bugs.webkit.org/show_bug.cgi?id=33769
+
+        * editing/selection/doubleclick-beside-cr-span.html:
+          Fix to compute click position using actual character width.
+
 2010-01-19  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/LayoutTests/editing/selection/doubleclick-beside-cr-span.html

@@ -23 +23 @@
 function doubleClickPosition(pos)
 {
-    eventSender.mouseMoveTo(pos.x + 2, pos.y + 2);
+    // Our test cases will have at most a single leading tab or four spaces,
+    // followed by a word which is wider than 4 "X"s.
+    // So, pos.x + CHAR_WIDTH * 4 always hits the words.
+    eventSender.mouseMoveTo(pos.x + CHAR_WIDTH * 4, pos.y + LINE_HEIGHT / 2);
     eventSender.mouseDown();
     eventSender.leapForward(1);
@@ -134 +137 @@
 }
 
-function getPositionForward(spanId, ncharacters)
-{
-   var pos = getPositionOfNode(spanId)
-   pos.x += CHAR_WIDTH*ncharacters;
-   return pos;
-}
-
 function runTests()
 {
@@ -161 +157 @@
         doTest("totest_word_before_here_in_line", "select10 ");
         doTest("totest_span_first_half", "select11 ");
-        doTest("totest_span_second_half", "select12 ");
+        doTest("totest_span_second_half", "selectHere12 ");
 
         doTest("totest_linebreak_out_pre", "select1");
@@ -168 +164 @@
         doTest("totest_linebreak_in_pre", "select4", getPositionOfNextLineHeadOf("totest_linebreak_in_pre"));
         doTest("totest_tab_in_pre", "select5\t");
-        doTest("totest_multiple_whitespaces_in_pre", "select6    ", getPositionForward("totest_multiple_whitespaces_in_pre", "    ".length));
+        doTest("totest_multiple_whitespaces_in_pre", "select6    ");
 
         doTest("totest_linebreak_out_prewrap", "select1");
@@ -187 +183 @@
         doTest("totest_tab_out_nowrap", "select2\t");
         doTest("totest_multiple_whitespaces_out_nowrap", "select3 ");
-        doTest("totest_linebreak_in_nowrap", "select4\n", getPositionForward("totest_linebreak_in_nowrap", 1));
-        doTest("totest_tab_in_nowrap", "select5\t", getPositionForward("totest_tab_in_nowrap", 1));
-        doTest("totest_multiple_whitespaces_in_nowrap", "select6 ", getPositionForward("totest_multiple_whitespaces_in_nowrap", 1));
+        doTest("totest_linebreak_in_nowrap", "select4\n");
+        doTest("totest_tab_in_nowrap", "select5\t");
+        doTest("totest_multiple_whitespaces_in_nowrap", "select6 ");
 
     }
@@ -286 +282 @@
 <div class="case">
 <h3>a second half of word is inside b element</h3>
-<div style="width:100pt">
-abcd efgh ijkl mnop qrst sel<b id="totest_span_second_half">ect12</b> notyet
+<!-- We choose selectHere12 instead select12 here
+     because <b>ect12</b> would be too short to be clicked by doubleClickPosition(). -->
+<div style="width:150pt">
+abcd efgh ijkl mnop qrst uvwx yz123 sel<b id="totest_span_second_half">ectHere12</b> notyet
 </div>
 </div>