Changeset 53539 in webkit

Timestamp:

Jan 20, 2010 3:28:04 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-01-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Teach check-webkit-style about WebKit/gtk/tests
​https://bugs.webkit.org/show_bug.cgi?id=33892

Removes false positives found in
​https://bugs.webkit.org/show_bug.cgi?id=30883

• Scripts/webkitpy/style/cpp_style.py:
• Scripts/webkitpy/style/cpp_style_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/cpp_style.py (modified) (1 diff)
• Scripts/webkitpy/style/cpp_style_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-20  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Teach check-webkit-style about WebKit/gtk/tests
+        https://bugs.webkit.org/show_bug.cgi?id=33892
+
+        Removes false positives found in
+        https://bugs.webkit.org/show_bug.cgi?id=30883
+
+        * Scripts/webkitpy/style/cpp_style.py:
+        * Scripts/webkitpy/style/cpp_style_unittest.py:
+
 2010-01-20  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/style/cpp_style.py

@@ -2937 +2937 @@
     if (filename.find('WebKit/qt/Api/') >= 0
         or filename.find('JavaScriptCore/qt/api/') >= 0
-        or filename.find('WebKit/qt/tests/') >= 0):
-        # The Qt API and tests do not follow WebKit style.
-        # They follow Qt style. :)
+        or filename.find('WebKit/qt/tests/') >= 0
+        or filename.find('WebKit/gtk/tests/') >= 0):
+        # The Qt API and the Qt and Gtk tests do not follow WebKit style.
         return True
 

trunk/WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py

@@ -3632 +3632 @@
         self.assert_(cpp_style.is_exempt('JavaScriptCore/qt/api/qscriptengine_p.h'))
         self.assert_(cpp_style.is_exempt('WebKit/qt/tests/qwebsecurityorigin/tst_qwebsecurityorigin.cpp'))
+        self.assert_(cpp_style.is_exempt('WebKit/gtk/tests/testatk.c'))
 
 def tearDown():