Changeset 53561 in webkit

Timestamp:

Jan 20, 2010 1:37:17 PM (14 years ago)

Author:

oliver@apple.com

Message:

2010-01-19 Oliver Hunt <​oliver@apple.com>

Reviewed by Beth Dakin.

Insufficient repaint issues with html embedded in foreignObject
​https://bugs.webkit.org/show_bug.cgi?id=16318

Partial fix for selection repaint in foreignObject, basically we
just need to make sure foreignObject correctly applies the svg
transform to the selection rect.

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintSelection):
• rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::mapLocalToContainer):
• rendering/RenderForeignObject.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBlock.cpp (modified) (1 diff)
• rendering/RenderForeignObject.cpp (modified) (1 diff)
• rendering/RenderForeignObject.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-01-19  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Beth Dakin.
+
+        Insufficient repaint issues with html embedded in foreignObject
+        https://bugs.webkit.org/show_bug.cgi?id=16318
+
+        Partial fix for selection repaint in foreignObject, basically we
+        just need to make sure foreignObject correctly applies the svg
+        transform to the selection rect.
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::paintSelection):
+        * rendering/RenderForeignObject.cpp:
+        (WebCore::RenderForeignObject::mapLocalToContainer):
+        * rendering/RenderForeignObject.h:
+
 2010-01-20  Kevin Ollivier  <kevino@theolliviers.com>
 

trunk/WebCore/rendering/RenderBlock.cpp

@@ -1958 +1958 @@
         if (!gapRectsBounds.isEmpty()) {
             if (RenderLayer* layer = enclosingLayer()) {
-                IntSize offset = hasLayer() ? IntSize() : offsetFromAncestorContainer(layer->renderer());
-                gapRectsBounds.move(offset - IntSize(tx, ty));
+                if (!hasLayer()) {
+                    FloatRect localBounds(gapRectsBounds);
+                    gapRectsBounds = localToContainerQuad(localBounds, layer->renderer()).enclosingBoundingBox();
+                }
                 layer->addBlockSelectionGapsBounds(gapRectsBounds);
             }

trunk/WebCore/rendering/RenderForeignObject.cpp

@@ -121 +121 @@
 }
 
+void RenderForeignObject::mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool fixed , bool useTransforms, TransformState& transformState) const
+{
+    SVGRenderBase::mapLocalToContainer(this, repaintContainer, fixed, useTransforms, transformState);
+}
+
 } // namespace WebCore
 

trunk/WebCore/rendering/RenderForeignObject.h

@@ -53 +53 @@
     virtual bool isSVGForeignObject() const { return true; }
 
+    virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool fixed , bool useTransforms, TransformState& transformState) const;
+
  private:
     TransformationMatrix translationForAttributes() const;