Changeset 53562 in webkit


Ignore:
Timestamp:
Jan 20, 2010 1:50:01 PM (14 years ago)
Author:
oliver@apple.com
Message:

2010-01-20 Oliver Hunt <​oliver@apple.com>

No review, rolling out r53561.
​http://trac.webkit.org/changeset/53561
​https://bugs.webkit.org/show_bug.cgi?id=16318

broke selection repaint for transformed text in html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintSelection):
  • rendering/RenderForeignObject.cpp:
  • rendering/RenderForeignObject.h:
Location:
trunk/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r53561 r53562  
     12010-01-20  Oliver Hunt  <oliver@apple.com>
     2
     3        No review, rolling out r53561.
     4        http://trac.webkit.org/changeset/53561
     5        https://bugs.webkit.org/show_bug.cgi?id=16318
     6
     7        broke selection repaint for transformed text in html
     8
     9        * rendering/RenderBlock.cpp:
     10        (WebCore::RenderBlock::paintSelection):
     11        * rendering/RenderForeignObject.cpp:
     12        * rendering/RenderForeignObject.h:
     13
    1142010-01-19  Oliver Hunt  <oliver@apple.com>
    215

  • trunk/WebCore/rendering/RenderBlock.cpp

    r53561 r53562  
    19581958        if (!gapRectsBounds.isEmpty()) {
    19591959            if (RenderLayer* layer = enclosingLayer()) {
    1960                 if (!hasLayer()) {
    1961                     FloatRect localBounds(gapRectsBounds);
    1962                     gapRectsBounds = localToContainerQuad(localBounds, layer->renderer()).enclosingBoundingBox();
    1963                 }
     1960                IntSize offset = hasLayer() ? IntSize() : offsetFromAncestorContainer(layer->renderer());
     1961                gapRectsBounds.move(offset - IntSize(tx, ty));
    19641962                layer->addBlockSelectionGapsBounds(gapRectsBounds);
    19651963            }

  • trunk/WebCore/rendering/RenderForeignObject.cpp

    r53561 r53562  
    121121}
    122122
    123 void RenderForeignObject::mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool fixed , bool useTransforms, TransformState& transformState) const
    124 {
    125     SVGRenderBase::mapLocalToContainer(this, repaintContainer, fixed, useTransforms, transformState);
    126 }
    127 
    128123} // namespace WebCore
    129124

  • trunk/WebCore/rendering/RenderForeignObject.h

    r53561 r53562  
    5353    virtual bool isSVGForeignObject() const { return true; }
    5454
    55     virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool fixed , bool useTransforms, TransformState& transformState) const;
    56 
    5755 private:
    5856    TransformationMatrix translationForAttributes() const;
Note: See TracChangeset for help on using the changeset viewer.