Changeset 53600 in webkit

Timestamp:

Jan 20, 2010 8:54:46 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-20 Stephen White <​senorblanco@chromium.org>

Reviewed by David Levin.

Disable the "seatbelt" coordinate validation functions in the
Skia graphics layer. We believe all the underlying bugs have
been fixed, but just in case we're being overly optimistic, this
leaves in the code for an easy revert.

​https://bugs.webkit.org/show_bug.cgi?id=33908
Exercised by many layout tests.

• platform/graphics/skia/GraphicsContextSkia.cpp:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/skia/GraphicsContextSkia.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-01-20  Stephen White  <senorblanco@chromium.org>
+
+        Reviewed by David Levin.
+
+        Disable the "seatbelt" coordinate validation functions in the
+        Skia graphics layer.  We believe all the underlying bugs have
+        been fixed, but just in case we're being overly optimistic, this
+        leaves in the code for an easy revert.
+
+        https://bugs.webkit.org/show_bug.cgi?id=33908
+        Exercised by many layout tests.
+
+        * platform/graphics/skia/GraphicsContextSkia.cpp:
+
 2010-01-20  Kent Tamura  <tkent@chromium.org>
 

trunk/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

@@ -87 +87 @@
 // have to do any checking. You can uncomment the ENSURE_VALUE_SAFETY_FOR_SKIA
 // flag to check the graphics layer.
-#define ENSURE_VALUE_SAFETY_FOR_SKIA
+
+// Disabling these checks (20/01/2010), since we think we've fixed all the Skia
+// bugs.  Leaving the code in for now, so we can revert easily if necessary.
+// #define ENSURE_VALUE_SAFETY_FOR_SKIA
 
 static bool isCoordinateSkiaSafe(float coord)