Changeset 53636 in webkit


Ignore:
Timestamp:
Jan 21, 2010 11:54:18 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-01-21 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
https://bugs.webkit.org/show_bug.cgi?id=33356

White list unix_hacker_style names in WebKit/gtk/webkit because these
are used in the GTK+ API.

  • Scripts/webkitpy/style/cpp_style.py:
  • Scripts/webkitpy/style/cpp_style_unittest.py:
Location:
trunk/WebKitTools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r53635 r53636  
     12010-01-21  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by David Levin.
     4
     5        [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
     6        https://bugs.webkit.org/show_bug.cgi?id=33356
     7
     8        White list unix_hacker_style names in WebKit/gtk/webkit because these
     9        are used in the GTK+ API.
     10
     11        * Scripts/webkitpy/style/cpp_style.py:
     12        * Scripts/webkitpy/style/cpp_style_unittest.py:
     13
    1142010-01-21  Diego Gonzalez  <diego.gonzalez@openbossa.org>
    215
  • trunk/WebKitTools/Scripts/webkitpy/style/cpp_style.py

    r53539 r53636  
    24702470            # Various exceptions to the rule: JavaScript op codes functions, const_iterator.
    24712471            if (not (filename.find('JavaScriptCore') >= 0 and modified_identifier.find('_op_') >= 0)
     2472                and not filename.find('WebKit/gtk/webkit/') >= 0
    24722473                and not modified_identifier.startswith('tst_')
    24732474                and not modified_identifier.startswith('webkit_dom_object_')
  • trunk/WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py

    r53539 r53636  
    35793579        self.assert_lint('void webkit_dom_object_class_init();', '')
    35803580
     3581        # The GTK+ APIs use GTK+ naming style, which includes lower-cased, _-separated values.
     3582        self.assert_lint('void this_is_a_gtk_style_name(int var1, int var2)', '', 'WebKit/gtk/webkit/foo.cpp')
     3583
    35813584        # There is an exception for some unit tests that begin with "tst_".
    35823585        self.assert_lint('void tst_QWebFrame::arrayObjectEnumerable(int var1, int var2)', '')
Note: See TracChangeset for help on using the changeset viewer.