Changeset 53734 in webkit

Timestamp:

Jan 22, 2010 4:21:53 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-01-22 Adam Barth <​abarth@webkit.org>

Rubber stamped by Eric Seidel.

Make init.py and buildbot.py pass pep8 style checker.

• Scripts/webkitpy/init.py:
• Scripts/webkitpy/buildbot.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/__init__.py (modified) (1 diff)
• Scripts/webkitpy/buildbot.py (modified) (6 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-22  Adam Barth  <abarth@webkit.org>
+
+        Rubber stamped by Eric Seidel.
+
+        Make __init__.py and buildbot.py pass pep8 style checker.
+
+        * Scripts/webkitpy/__init__.py:
+        * Scripts/webkitpy/buildbot.py:
+
 2010-01-21  Joe Mason  <jmason@rim.com>
 

trunk/WebKitTools/Scripts/webkitpy/__init__.py

@@ -3 +3 @@
 import autoinstall
 
-# List our third-party library dependencies here and where they can be downloaded.
+# List our third-party library dependencies here and where they can be
+# downloaded.
 autoinstall.bind("ClientForm", "http://pypi.python.org/packages/source/C/ClientForm/ClientForm-0.2.10.zip", "ClientForm-0.2.10")
 autoinstall.bind("mechanize", "http://pypi.python.org/packages/source/m/mechanize/mechanize-0.1.11.zip", "mechanize-0.1.11")

trunk/WebKitTools/Scripts/webkitpy/buildbot.py

@@ -1 +1 @@
 # Copyright (c) 2009, Google Inc. All rights reserved.
-# 
+#
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
-# 
+#
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
@@ -14 +14 @@
 # contributors may be used to endorse or promote products derived from
 # this software without specific prior written permission.
-# 
+#
 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
@@ -39 +39 @@
 from .BeautifulSoup import BeautifulSoup
 
+
 class BuildBot:
+
     default_host = "build.webkit.org"
+
     def __init__(self, host=default_host):
         self.buildbot_host = host
         self.buildbot_server_url = "http://%s/" % self.buildbot_host
-        
-        # If any Leopard builder/tester, Windows builder or Chromium builder is red we should not be landing patches.
-        # Other builders should be added to this list once they are known to be reliable.
+
+        # If any Leopard builder/tester, Windows builder or Chromium builder is
+        # red we should not be landing patches.  Other builders should be added
+        # to this list once they are known to be reliable.
         # See https://bugs.webkit.org/show_bug.cgi?id=33296 and related bugs.
-        self.core_builder_names_regexps = [ "Leopard", "Windows.*Build", "Chromium" ]
+        self.core_builder_names_regexps = [
+            "Leopard",
+            "Windows.*Build",
+            "Chromium",
+        ]
 
-    # If WebKit's buildbot has an XMLRPC interface we could use, we could do something more sophisticated here.
-    # For now we just parse out the basics, enough to support basic questions like "is the tree green?"
     def _parse_builder_status_from_row(self, status_row):
+        # If WebKit's buildbot has an XMLRPC interface we could use, we could
+        # do something more sophisticated here.  For now we just parse out the
+        # basics, enough to support basic questions like "is the tree green?"
         status_cells = status_row.findAll('td')
         builder = {}
@@ -58 +67 @@
         name_link = status_cells[0].find('a')
         builder['name'] = name_link.string
-        # We could generate the builder_url from the name in a future version of this code.
+        # We could generate the builder_url from the name in a future version
+        # of this code.
         builder['builder_url'] = self.buildbot_server_url + name_link['href']
 
         status_link = status_cells[1].find('a')
         if not status_link:
-            # We failed to find a link in the first cell, just give up.
-            # This can happen if a builder is just-added, the first cell will just be "no build"
-            builder['is_green'] = False # Other parts of the code depend on is_green being present.
+            # We failed to find a link in the first cell, just give up.  This
+            # can happen if a builder is just-added, the first cell will just
+            # be "no build"
+            # Other parts of the code depend on is_green being present.
+            builder['is_green'] = False
             return builder
-        revision_string = status_link.string # Will be either a revision number or a build number
+        # Will be either a revision number or a build number
+        revision_string = status_link.string
         # If revision_string has non-digits assume it's not a revision number.
-        builder['built_revision'] = int(revision_string) if not re.match('\D', revision_string) else None
-        builder['is_green'] = not re.search('fail', status_cells[1].renderContents())
-        # We could parse out the build number instead, but for now just store the URL.
+        builder['built_revision'] = int(revision_string) \
+                                    if not re.match('\D', revision_string) \
+                                    else None
+        builder['is_green'] = not re.search('fail',
+                                            status_cells[1].renderContents())
+        # We could parse out the build number instead, but for now just store
+        # the URL.
         builder['build_url'] = self.buildbot_server_url + status_link['href']
 
@@ -78 +95 @@
         return builder
 
-    def _builder_statuses_with_names_matching_regexps(self, builder_statuses, name_regexps):
+    def _builder_statuses_with_names_matching_regexps(self,
+                                                      builder_statuses,
+                                                      name_regexps):
         builders = []
         for builder in builder_statuses:
@@ -88 +107 @@
     def red_core_builders(self):
         red_builders = []
-        for builder in self._builder_statuses_with_names_matching_regexps(self.builder_statuses(), self.core_builder_names_regexps):
+        for builder in self._builder_statuses_with_names_matching_regexps(
+                               self.builder_statuses(),
+                               self.core_builder_names_regexps):
             if not builder['is_green']:
                 red_builders.append(builder)