Changeset 53809 in webkit
- Timestamp:
- Jan 25, 2010 11:20:06 AM (14 years ago)
- Location:
- trunk/WebCore
- Files:
-
- 62 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r53808 r53809 1 2010-01-25 Daniel Bates <dbates@webkit.org> 2 3 Reviewed by Adam Barth. 4 5 https://bugs.webkit.org/show_bug.cgi?id=34073 6 7 Fixes misspelled words in comments. 8 9 * accessibility/AccessibilityListBox.cpp: 10 (WebCore::AccessibilityListBox::addChildren): 11 (WebCore::AccessibilityListBox::doAccessibilityHitTest): 12 * accessibility/mac/AccessibilityObjectWrapper.mm: 13 (-[AccessibilityObjectWrapper detach]): 14 (AXAttributeStringSetElement): 15 * bindings/js/JSDOMBinding.cpp: 16 (WebCore::completeURL): 17 * bindings/js/JSDOMWindowBase.cpp: 18 * bindings/js/JSDOMWindowBase.h: 19 * bindings/js/JSDOMWindowCustom.cpp: 20 (WebCore::JSDOMWindow::getOwnPropertySlot): 21 * bindings/js/JSSVGPODTypeWrapper.h: 22 * bindings/js/ScriptController.cpp: 23 (WebCore::ScriptController::evaluateInWorld): 24 * bridge/NP_jsobject.cpp: 25 (_NPN_SetException): 26 * bridge/jni/jsc/JavaInstanceJSC.cpp: 27 (JavaInstance::invokeMethod): 28 (JObjectWrapper::JObjectWrapper): 29 * bridge/objc/objc_instance.mm: 30 (ObjcInstance::setValueOfUndefinedField): 31 (ObjcInstance::getValueOfUndefinedField): 32 * css/CSSFontSelector.cpp: 33 (WebCore::CSSFontSelector::addFontFaceRule): 34 * css/CSSStyleSelector.cpp: 35 (WebCore::CSSStyleSelector::CSSStyleSelector): 36 (WebCore::CSSStyleSelector::sortMatchedRules): 37 (WebCore::CSSStyleSelector::applyDeclarations): 38 (WebCore::CSSStyleSelector::applyProperty): 39 * dom/Document.cpp: 40 (WebCore::Document::updateLayoutIgnorePendingStylesheets): 41 (WebCore::Document::detach): 42 * dom/Document.h: 43 * dom/Element.cpp: 44 (WebCore::Element::updateFocusAppearance): 45 * dom/Element.h: 46 * dom/MessagePortChannel.h: 47 * dom/MouseRelatedEvent.cpp: 48 (WebCore::MouseRelatedEvent::receivedTarget): 49 * dom/Node.cpp: 50 (WebCore::Node::isFocusable): 51 (WebCore::Node::shadowAncestorNode): 52 * dom/Node.h: 53 * dom/Position.cpp: 54 (WebCore::Position::upstream): 55 * dom/Position.h: 56 * dom/Range.cpp: 57 (WebCore::Range::processContents): 58 * dom/StyledElement.cpp: 59 (WebCore::StyledElement::addCSSColor): 60 * editing/ApplyStyleCommand.cpp: 61 (WebCore::StyleChange::reconcileTextDecorationProperties): 62 (WebCore::StyleChange::extractTextStyles): 63 (WebCore::prepareEditingStyleToApplyAt): 64 * editing/DeleteButtonController.cpp: 65 (WebCore::isDeletableElement): 66 * editing/DeleteSelectionCommand.cpp: 67 (WebCore::DeleteSelectionCommand::initializeStartEnd): 68 * editing/Editor.cpp: 69 (WebCore::Editor::learnSpelling): 70 * inspector/front-end/ConsoleView.js: 71 (WebInspector.ConsoleMessage.prototype._format): 72 * loader/Cache.cpp: 73 (WebCore::Cache::pruneLiveResources): 74 (WebCore::Cache::pruneDeadResources): 75 * loader/Cache.h: 76 * loader/CachedResource.cpp: 77 (WebCore::CachedResource::makePurgeable): 78 * loader/CachedResource.h: 79 * loader/CachedResourceHandle.h: 80 * loader/DocumentLoader.h: 81 * loader/FTPDirectoryParser.cpp: 82 (WebCore::parseOneFTPLine): 83 * loader/FrameLoader.cpp: 84 (WebCore::FrameLoader::didExplicitOpen): 85 * loader/ResourceLoader.cpp: 86 (WebCore::ResourceLoader::didCancel): 87 * loader/WorkerThreadableLoader.h: 88 * loader/appcache/ApplicationCacheStorage.cpp: 89 (WebCore::ApplicationCacheStorage::spaceNeeded): 90 * notifications/NotificationPresenter.h: 91 (WebCore::NotificationPresenter::): 92 * page/animation/AnimationController.cpp: 93 (WebCore::AnimationController::updateAnimations): 94 * platform/LinkHash.cpp: 95 (WebCore::cleanPath): 96 * platform/graphics/cg/GraphicsContextCG.cpp: 97 (WebCore::calculateDrawingMode): 98 * platform/graphics/cg/PatternCG.cpp: 99 (WebCore::Pattern::createPlatformPattern): 100 * platform/graphics/mac/ComplexTextController.cpp: 101 (WebCore::ComplexTextController::offsetForPosition): 102 * platform/graphics/mac/GraphicsLayerCA.h: 103 * platform/graphics/mac/GraphicsLayerCA.mm: 104 (WebCore::GraphicsLayerCA::ensureStructuralLayer): 105 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: 106 (WebCore::MediaPlayerPrivate::doSeek): 107 (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible): 108 (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame): 109 * platform/mac/PasteboardMac.mm: 110 (WebCore::Pasteboard::writeSelection): 111 (WebCore::Pasteboard::writePlainText): 112 (WebCore::Pasteboard::writeURL): 113 * platform/text/TextCodecICU.cpp: 114 (WebCore::TextCodecICU::registerExtendedEncodingNames): 115 * platform/text/TextEncodingDetectorICU.cpp: 116 (WebCore::detectTextEncoding): 117 * rendering/AutoTableLayout.cpp: 118 (WebCore::AutoTableLayout::calcEffectiveWidth): 119 (WebCore::AutoTableLayout::layout): 120 * rendering/RenderBox.cpp: 121 (WebCore::RenderBox::calcAbsoluteHorizontalValues): 122 (WebCore::RenderBox::calcAbsoluteVerticalValues): 123 (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): 124 (WebCore::RenderBox::calcAbsoluteVerticalReplaced): 125 * rendering/RenderLayer.cpp: 126 (WebCore::RenderLayer::scrollByRecursively): 127 (WebCore::RenderLayer::paintLayer): 128 (WebCore::RenderLayer::hitTestLayer): 129 * rendering/RenderObject.cpp: 130 (WebCore::RenderObject::destroy): 131 * rendering/RenderTextControl.cpp: 132 (WebCore::RenderTextControl::setInnerTextValue): 133 * rendering/RenderTheme.cpp: 134 (WebCore::RenderTheme::stateChanged): 135 * rendering/SVGRenderSupport.cpp: 136 (WebCore::SVGRenderBase::mapLocalToContainer): 137 * rendering/SVGRootInlineBox.cpp: 138 (WebCore::SVGRootInlineBox::buildTextChunks): 139 * rendering/TransformState.cpp: 140 (WebCore::TransformState::flattenWithTransform): 141 * wml/WMLInputElement.cpp: 142 (WebCore::WMLInputElement::dispatchBlurEvent): 143 (WebCore::WMLInputElement::suggestedValue): 144 1 145 2010-01-25 Geoffrey Garen <ggaren@apple.com> 2 146 -
trunk/WebCore/accessibility/AccessibilityListBox.cpp
r50444 r53809 79 79 for (unsigned i = 0; i < length; i++) { 80 80 // The cast to HTMLElement below is safe because the only other possible listItem type 81 // would be a WMLElement, but WML builds don't use access bility features at all.81 // would be a WMLElement, but WML builds don't use accessibility features at all. 82 82 AccessibilityObject* listOption = listBoxOptionAccessibilityObject(static_cast<HTMLElement*>(listItems[i])); 83 83 if (listOption) … … 171 171 IntRect rect = toRenderListBox(m_renderer)->itemBoundingBoxRect(parentRect.x(), parentRect.y(), i); 172 172 // The cast to HTMLElement below is safe because the only other possible listItem type 173 // would be a WMLElement, but WML builds don't use access bility features at all.173 // would be a WMLElement, but WML builds don't use accessibility features at all. 174 174 if (rect.contains(point)) 175 175 return listBoxOptionAccessibilityObject(static_cast<HTMLElement*>(listItems[i])); -
trunk/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm
r52994 r53809 193 193 { 194 194 // Send unregisterUniqueIdForUIElement unconditionally because if it is 195 // ever accident ly not done (via other bugs in our AX implementation) you195 // ever accidentally not done (via other bugs in our AX implementation) you 196 196 // end up with a crash like <rdar://problem/4273149>. It is safe and not 197 197 // expensive to send even if the object is not registered. … … 439 439 { 440 440 if (object && object->isAccessibilityRenderObject()) { 441 // make a seriali azable AX object441 // make a serializable AX object 442 442 443 443 RenderObject* renderer = static_cast<AccessibilityRenderObject*>(object)->renderer(); -
trunk/WebCore/bindings/js/JSDOMBinding.cpp
r53808 r53809 782 782 KURL completeURL(ExecState* exec, const String& relativeURL) 783 783 { 784 // For histo ical reasons, we need to complete the URL using the dynamic frame.784 // For historical reasons, we need to complete the URL using the dynamic frame. 785 785 Frame* frame = toDynamicFrame(exec); 786 786 if (!frame) -
trunk/WebCore/bindings/js/JSDOMWindowBase.cpp
r53785 r53809 172 172 } 173 173 174 // JSDOMGlobalObject* is ignored, acces ing a window in any context will174 // JSDOMGlobalObject* is ignored, accessing a window in any context will 175 175 // use that DOMWindow's prototype chain. 176 176 JSValue toJS(ExecState* exec, JSDOMGlobalObject*, DOMWindow* domWindow) -
trunk/WebCore/bindings/js/JSDOMWindowBase.h
r51512 r53809 93 93 94 94 // Returns a JSDOMWindow or jsNull() 95 // JSDOMGlobalObject* is ignored, acces ing a window in any context will95 // JSDOMGlobalObject* is ignored, accessing a window in any context will 96 96 // use that DOMWindow's prototype chain. 97 97 JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, DOMWindow*); -
trunk/WebCore/bindings/js/JSDOMWindowCustom.cpp
r53706 r53809 268 268 } 269 269 270 // FIXME: Search the whole frame hiera chy somewhere around here.270 // FIXME: Search the whole frame hierarchy somewhere around here. 271 271 // We need to test the correct priority order. 272 272 -
trunk/WebCore/bindings/js/JSSVGPODTypeWrapper.h
r53666 r53809 50 50 // passed around as const reference. SVG DOM demands these objects to be "live", changes to any 51 51 // of the writable attributes of SVGMatrix need to be reflected in the object which exposed the 52 // SVGMatrix object (i e. 'someElement.transform.matrix.a = 50.0', in that case 'SVGTransform').52 // SVGMatrix object (i.e. 'someElement.transform.matrix.a = 50.0', in that case 'SVGTransform'). 53 53 // The SVGTransform class stores its "TransformationMatrix m_matrix" object on the stack. If it would 54 54 // be stored as pointer we could just build an auto-generated JSSVG* wrapper object around it … … 115 115 }; 116 116 117 // Represents a JS wrapper object for SVG POD types (not for SVGAnimated* clas es). Any modification to the SVG POD117 // Represents a JS wrapper object for SVG POD types (not for SVGAnimated* classes). Any modification to the SVG POD 118 118 // types don't cause any updates unlike JSSVGDynamicPODTypeWrapper. This class is used for return values (ie. getBBox()) 119 // and for properties where SVG specification explicit ely states, that the contents of the POD type are immutable.119 // and for properties where SVG specification explicitly states, that the contents of the POD type are immutable. 120 120 121 121 template<typename PODType> -
trunk/WebCore/bindings/js/ScriptController.cpp
r53766 r53809 103 103 104 104 // evaluate code. Returns the JS return value or 0 105 // if there was none, an error occur ed or the type couldn't be converted.105 // if there was none, an error occurred or the type couldn't be converted. 106 106 107 107 // inlineCode is true for <a href="javascript:doSomething()"> -
trunk/WebCore/bridge/NP_jsobject.cpp
r51512 r53809 380 380 void _NPN_SetException(NPObject*, const NPUTF8* message) 381 381 { 382 // Ignor ning the NPObject param is consistent with the Mozilla implementation.382 // Ignoring the NPObject param is consistent with the Mozilla implementation. 383 383 UString exception(message); 384 384 CInstance::setGlobalException(exception); -
trunk/WebCore/bridge/jni/jsc/JavaInstanceJSC.cpp
r53557 r53809 153 153 154 154 // Try to use the JNI abstraction first, otherwise fall back to 155 // nor nmal JNI. The JNI dispatch abstraction allows the Java plugin155 // normal JNI. The JNI dispatch abstraction allows the Java plugin 156 156 // to dispatch the call on the appropriate internal VM thread. 157 157 RootObject* rootObject = this->rootObject(); … … 321 321 assert(instance); 322 322 323 // Cache the JNIEnv used to get the global ref for this java instan ace.323 // Cache the JNIEnv used to get the global ref for this java instance. 324 324 // It'll be used to delete the reference. 325 325 m_env = getJNIEnv(); -
trunk/WebCore/bridge/objc/objc_instance.mm
r53541 r53809 349 349 350 350 // This check is not really necessary because NSObject implements 351 // setValue:forUndefinedKey:, and unfort nately the default implementation351 // setValue:forUndefinedKey:, and unfortunately the default implementation 352 352 // throws an exception. 353 353 if ([targetObject respondsToSelector:@selector(setValue:forUndefinedKey:)]){ … … 377 377 378 378 // This check is not really necessary because NSObject implements 379 // valueForUndefinedKey:, and unfort nately the default implementation379 // valueForUndefinedKey:, and unfortunately the default implementation 380 380 // throws an exception. 381 381 if ([targetObject respondsToSelector:@selector(valueForUndefinedKey:)]){ -
trunk/WebCore/css/CSSStyleSelector.cpp
r53709 r53809 442 442 443 443 if (root) 444 m_rootDefaultStyle = styleForElement(root, 0, false, true); // don t ref, because the RenderStyle is allocated from global heap444 m_rootDefaultStyle = styleForElement(root, 0, false, true); // don't ref, because the RenderStyle is allocated from global heap 445 445 446 446 if (m_rootDefaultStyle && view) { … … 464 464 m_authorStyle = new CSSRuleSet(); 465 465 466 // Add rules from el ments like SVG's <font-face>466 // Add rules from elements like SVG's <font-face> 467 467 if (mappedElementSheet) 468 468 m_authorStyle->addRulesFromSheet(mappedElementSheet, *m_medium, this); … … 760 760 } 761 761 762 // Pe form a merge sort for larger lists.762 // Perform a merge sort for larger lists. 763 763 unsigned mid = (start + end) / 2; 764 764 sortMatchedRules(start, mid); … … 2875 2875 case CSSPropertyZoom: 2876 2876 // these have to be applied first, because other properties use the computed 2877 // values of these p orperties.2877 // values of these properties. 2878 2878 first = true; 2879 2879 break; … … 3040 3040 if (primitiveValue) { 3041 3041 if (primitiveValue->getIdent() == CSSValueWapMarquee) { 3042 // Initialize W apMarquee style3042 // Initialize WAP Marquee style 3043 3043 m_style->setOverflowX(OMARQUEE); 3044 3044 m_style->setOverflowY(OMARQUEE); -
trunk/WebCore/dom/Document.cpp
r53607 r53809 1468 1468 // If new nodes have been added or style recalc has been done with style sheets still pending, some nodes 1469 1469 // may not have had their real style calculated yet. Normally this gets cleaned when style sheets arrive 1470 // but here we need up-to-date style immediat ly.1470 // but here we need up-to-date style immediately. 1471 1471 recalcStyle(Force); 1472 1472 } … … 1555 1555 1556 1556 // This is required, as our Frame might delete itself as soon as it detaches 1557 // us. However, this violates Node::detach() s ymantics, as it's never1557 // us. However, this violates Node::detach() semantics, as it's never 1558 1558 // possible to re-attach. Eventually Document::detach() should be renamed, 1559 1559 // or this setting of the frame to 0 could be made explicit in each of the … … 4547 4547 } 4548 4548 4549 // FF method for accessing the selection added for compat ability.4549 // FF method for accessing the selection added for compatibility. 4550 4550 DOMSelection* Document::getSelection() const 4551 4551 { -
trunk/WebCore/dom/Document.h
r53595 r53809 824 824 void cancelFocusAppearanceUpdate(); 825 825 826 // FF method for accessing the selection added for compat ability.826 // FF method for accessing the selection added for compatibility. 827 827 DOMSelection* getSelection() const; 828 828 -
trunk/WebCore/dom/Element.cpp
r53736 r53809 1279 1279 } 1280 1280 // FIXME: I'm not sure all devices will want this off, but this is 1281 // currently turned off for Andr iod.1281 // currently turned off for Android. 1282 1282 #if !ENABLE(DIRECTIONAL_PAD_NAVIGATION) 1283 1283 else if (renderer() && !renderer()->isWidget()) -
trunk/WebCore/dom/Element.h
r53548 r53809 75 75 DEFINE_ATTRIBUTE_EVENT_LISTENER(submit); 76 76 77 // These 4 attribute event handler attributes are overridedby HTMLBodyElement77 // These four attribute event handler attributes are overridden by HTMLBodyElement 78 78 // and HTMLFrameSetElement to forward to the DOMWindow. 79 79 DEFINE_VIRTUAL_ATTRIBUTE_EVENT_LISTENER(blur); -
trunk/WebCore/dom/MessagePortChannel.h
r50464 r53809 63 63 static PassOwnPtr<MessagePortChannel> create(PassRefPtr<PlatformMessagePortChannel>); 64 64 65 // Entangles the channel with a port (called when a port has been cloned, after the clone has been marshal led to its new owning thread and is ready to receive messages).65 // Entangles the channel with a port (called when a port has been cloned, after the clone has been marshaled to its new owning thread and is ready to receive messages). 66 66 // Returns false if the entanglement failed because the port was closed. 67 67 bool entangleIfOpen(MessagePort*); -
trunk/WebCore/dom/MouseRelatedEvent.cpp
r49551 r53809 152 152 153 153 // Adjust layerX/Y to be relative to the layer. 154 // FIXME: We're pretty sure this is the wrong defin tion of "layer."154 // FIXME: We're pretty sure this is the wrong definition of "layer." 155 155 // Our RenderLayer is a more modern concept, and layerX/Y is some 156 156 // other notion about groups of elements (left over from the Netscape 4 days?); -
trunk/WebCore/dom/Node.cpp
r53564 r53809 850 850 else 851 851 // If the node is in a display:none tree it might say it needs style recalc but 852 // the whole document is a tually up to date.852 // the whole document is actually up to date. 853 853 ASSERT(!document()->childNeedsStyleRecalc()); 854 854 … … 1468 1468 { 1469 1469 #if ENABLE(SVG) 1470 // SVG elements living in a shadow tree only occ our when <use> created them.1470 // SVG elements living in a shadow tree only occur when <use> created them. 1471 1471 // For these cases we do NOT want to return the shadowParentNode() here 1472 1472 // but the actual shadow tree element - as main difference to the HTML forms -
trunk/WebCore/dom/Node.h
r53690 r53809 252 252 253 253 // Called by the parser when this element's close tag is reached, 254 // signal ling that all child tags have been parsed and added.254 // signaling that all child tags have been parsed and added. 255 255 // This is needed for <applet> and <object> elements, which can't lay themselves out 256 256 // until they know all of their nested <param>s. [Radar 3603191, 4040848]. -
trunk/WebCore/dom/Position.cpp
r53494 r53809 499 499 } 500 500 501 // If we've moved to a position that is visually dis inct, return the last saved position. There501 // If we've moved to a position that is visually distinct, return the last saved position. There 502 502 // is code below that terminates early if we're *about* to move to a visually distinct position. 503 503 if (endsOfNodeAreVisuallyDistinctPositions(currentNode) && currentNode != boundary) -
trunk/WebCore/dom/Position.h
r51522 r53809 136 136 bool atLastEditingPositionForNode() const; 137 137 138 // Retu ns true if the visually equivalent positions around have different editability138 // Returns true if the visually equivalent positions around have different editability 139 139 bool atEditingBoundary() const; 140 140 -
trunk/WebCore/dom/Range.cpp
r52388 r53809 667 667 668 668 // Complex case: Start and end containers are different. 669 // There are three possib lities here:669 // There are three possibilities here: 670 670 // 1. Start container == commonRoot (End container must be a descendant) 671 671 // 2. End container == commonRoot (Start container must be a descendant) -
trunk/WebCore/dom/StyledElement.cpp
r52312 r53809 347 347 348 348 // we're emulating IEs color parser here. It maps transparent to black, otherwise it tries to build a rgb value 349 // out of every hting you put in. The algorithm is experimentally determined, but seems to work for all test cases I have.349 // out of everything you put in. The algorithm is experimentally determined, but seems to work for all test cases I have. 350 350 351 351 // the length of the color value is rounded up to the next -
trunk/WebCore/editing/ApplyStyleCommand.cpp
r53680 r53809 138 138 } 139 139 140 // If text-dec ration is set to "none", remove the property because we don't want to add redundant "text-decoration: none".140 // If text-decoration is set to "none", remove the property because we don't want to add redundant "text-decoration: none". 141 141 if (textDecoration && !textDecoration->isValueList()) 142 142 style->removeProperty(CSSPropertyTextDecoration); … … 251 251 m_applyFontSize = "7"; 252 252 } 253 // Huge quirk in Micros ft Entourage is that they understand CSS font-size, but also write253 // Huge quirk in Microsoft Entourage is that they understand CSS font-size, but also write 254 254 // out legacy 1-7 values in font tags (I guess for mailers that are not CSS-savvy at all, 255 255 // like Eudora). Yes, they write out *both*. We need to write out both as well. … … 452 452 void prepareEditingStyleToApplyAt(CSSMutableStyleDeclaration* editingStyle, Position pos) 453 453 { 454 // ReplaceSelectionCommand::handleStyleSpans() requi ers that this function only removes the editing style.455 // If this function was modified in the future to delete all redundant properties, then add a boolean value to indicate454 // ReplaceSelectionCommand::handleStyleSpans() requires that this function only removes the editing style. 455 // If this function was modified in the future to delete all redundant properties, then add a boolean value to indicate 456 456 // which one of editingStyleAtPosition or computedStyle is called. 457 457 RefPtr<CSSMutableStyleDeclaration> style = editingStyleAtPosition(pos); -
trunk/WebCore/editing/DeleteButtonController.cpp
r52312 r53809 67 67 return false; 68 68 69 // In general we want to only draw the UI ar round object of a certain area, but we still keep the min width/height to69 // In general we want to only draw the UI around object of a certain area, but we still keep the min width/height to 70 70 // make sure we don't end up with very thin or very short elements getting the UI. 71 71 const int minimumArea = 2500; -
trunk/WebCore/editing/DeleteSelectionCommand.cpp
r53085 r53809 122 122 end = Position(end.node(), 1); 123 123 124 // FIXME: This is only used so that moveParagraphs can avoid the bugs in special element expan ion.124 // FIXME: This is only used so that moveParagraphs can avoid the bugs in special element expansion. 125 125 if (!m_expandForSpecialElements) 126 126 return; -
trunk/WebCore/editing/Editor.cpp
r53068 r53809 1503 1503 return; 1504 1504 1505 // FIXME: We don't call this on the Mac, and it should remove mis ppelling markers around the1505 // FIXME: We don't call this on the Mac, and it should remove misspelling markers around the 1506 1506 // learned word, see <rdar://problem/5396072>. 1507 1507 -
trunk/WebCore/inspector/front-end/ConsoleView.js
r53766 r53809 637 637 _format: function(parameters) 638 638 { 639 // This node is used like a Builder. Values are contin tually appended onto it.639 // This node is used like a Builder. Values are continually appended onto it. 640 640 var formattedResult = document.createElement("span"); 641 641 if (!parameters.length) … … 690 690 // Firebug allows both %i and %d for formatting integers. 691 691 formatters.i = formatters.d; 692 // Support %O to force object format ing, instead of the type-based %o formatting.692 // Support %O to force object formatting, instead of the type-based %o formatting. 693 693 formatters.O = consoleFormatWrapper(true); 694 694 -
trunk/WebCore/loader/Cache.cpp
r53292 r53809 296 296 297 297 // Destroy our decoded data. This will remove us from 298 // m_liveDecodedResources, and possibly move us to a differ nt LRU298 // m_liveDecodedResources, and possibly move us to a different LRU 299 299 // list in m_allResources. 300 300 current->destroyDecodedData(); … … 348 348 if (!current->hasClients() && !current->isPreloaded() && current->isLoaded()) { 349 349 // Destroy our decoded data. This will remove us from 350 // m_liveDecodedResources, and possibly move us to a differ nt350 // m_liveDecodedResources, and possibly move us to a different 351 351 // LRU list in m_allResources. 352 352 current->destroyDecodedData(); -
trunk/WebCore/loader/Cache.h
r45891 r53809 191 191 192 192 // Size-adjusted and popularity-aware LRU list collection for cache objects. This collection can hold 193 // more resources than the cached resource map, since it can also hold "stale" mu iltiple versions of objects that are193 // more resources than the cached resource map, since it can also hold "stale" multiple versions of objects that are 194 194 // waiting to die when the clients referencing them go away. 195 195 Vector<LRUList, 32> m_allResources; -
trunk/WebCore/loader/CachedResource.cpp
r52177 r53809 432 432 return false; 433 433 434 // Should not make buffer purgeable if it has refs othe nthan this since we don't want two copies.434 // Should not make buffer purgeable if it has refs other than this since we don't want two copies. 435 435 if (!m_data->hasOneRef()) 436 436 return false; -
trunk/WebCore/loader/CachedResource.h
r52177 r53809 150 150 virtual bool schedule() const { return false; } 151 151 152 // List of acceptable MIME types sep erated by ",".152 // List of acceptable MIME types separated by ",". 153 153 // A MIME type may contain a wildcard, e.g. "text/*". 154 154 String accept() const { return m_accept; } -
trunk/WebCore/loader/CachedResourceHandle.h
r49556 r53809 73 73 }; 74 74 75 // Don't inline for winscw compiler to prevent the compiler ag ressively resolving75 // Don't inline for winscw compiler to prevent the compiler aggressively resolving 76 76 // the base class of R* when CachedResourceHandler<T>(R*) is inlined. The bug is 77 77 // reported at: https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812. -
trunk/WebCore/loader/DocumentLoader.h
r51644 r53809 155 155 bool urlForHistoryReflectsFailure() const; 156 156 157 // These accessors accom odate WebCore's somewhat fickle custom of creating history157 // These accessors accommodate WebCore's somewhat fickle custom of creating history 158 158 // items for redirects, but only sometimes. For "source" and "destination", 159 159 // these accessors return the URL that would have been used if a history -
trunk/WebCore/loader/FTPDirectoryParser.cpp
r52791 r53809 1186 1186 } /* time/year */ 1187 1187 1188 // there is exac ly 1 space between filename and previous token in all1188 // there is exactly 1 space between filename and previous token in all 1189 1189 // outputs except old Hellsoft 1190 1190 if (!isOldHellsoft) -
trunk/WebCore/loader/FrameLoader.cpp
r53737 r53809 672 672 // Prevent window.open(url) -- eg window.open("about:blank") -- from blowing away results 673 673 // from a subsequent window.document.open / window.document.write call. 674 // Cancel ling redirection here works for all cases because document.open674 // Canceling redirection here works for all cases because document.open 675 675 // implicitly precedes document.write. 676 676 m_frame->redirectScheduler()->cancel(); -
trunk/WebCore/loader/ResourceLoader.cpp
r52860 r53809 319 319 // changes the window location). This is used to prevent both the body 320 320 // of this method and the body of connectionDidFinishLoading: running 321 // for a single delegate. Cancel ling wins.321 // for a single delegate. Canceling wins. 322 322 m_cancelled = true; 323 323 -
trunk/WebCore/loader/WorkerThreadableLoader.h
r53568 r53809 83 83 // all cases. All tasks posted from the worker context's thread are ok because 84 84 // the last task posted always is "mainThreadDestroy", so MainThreadBridge is 85 // around for all tasks that use it on the m ian thread.85 // around for all tasks that use it on the main thread. 86 86 // 87 87 // case 1. worker.terminate is called. -
trunk/WebCore/loader/appcache/ApplicationCacheStorage.cpp
r47907 r53809 406 406 } 407 407 408 // The space needed to be freed in order to accom odate the failed cache is408 // The space needed to be freed in order to accommodate the failed cache is 409 409 // the size of the failed cache minus any already available free space. 410 410 spaceNeeded = cacheToSave - totalAvailableSize; -
trunk/WebCore/notifications/NotificationPresenter.h
r47793 r53809 47 47 public: 48 48 enum Permission { 49 PermissionAllowed, 50 PermissionNotAllowed, 51 PermissionDenied // User has explictly denied permission49 PermissionAllowed, // User has allowed notifications 50 PermissionNotAllowed, // User has not yet allowed 51 PermissionDenied // User has explicitly denied permission 52 52 }; 53 53 -
trunk/WebCore/page/animation/AnimationController.cpp
r49633 r53809 485 485 486 486 if (blendedStyle != newStyle) { 487 // If the animations/transitions change opacity or transform, we nee ed to update487 // If the animations/transitions change opacity or transform, we need to update 488 488 // the style to impose the stacking rules. Note that this is also 489 489 // done in CSSStyleSelector::adjustRenderStyle(). -
trunk/WebCore/platform/LinkHash.cpp
r43052 r53809 82 82 static inline void cleanPath(Vector<UChar, 512>& path) 83 83 { 84 // FIXME: Sho ld not do this in the query or anchor part.84 // FIXME: Should not do this in the query or anchor part. 85 85 int pos; 86 86 while ((pos = findSlashDotDotSlash(path.data(), path.size())) != -1) { … … 93 93 } 94 94 95 // FIXME: Sho ld not do this in the query part.95 // FIXME: Should not do this in the query part. 96 96 // Set refPos to -2 to mean "I haven't looked for the anchor yet". 97 97 // We don't want to waste a function call on the search for the the anchor … … 111 111 } 112 112 113 // FIXME: Sho ld not do this in the query or anchor part.113 // FIXME: Should not do this in the query or anchor part. 114 114 while ((pos = findSlashDotSlash(path.data(), path.size())) != -1) 115 115 path.remove(pos, 2); -
trunk/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
r53237 r53809 499 499 } else { 500 500 // Setting mode to kCGPathStroke even if shouldStroke is false. In that case, we return false and mode will not be used, 501 // but the compiler will not comp ain about an uninitialized variable.501 // but the compiler will not complain about an uninitialized variable. 502 502 mode = kCGPathStroke; 503 503 } -
trunk/WebCore/platform/graphics/cg/PatternCG.cpp
r46399 r53809 62 62 // If FLT_MAX should also be used for xStep or yStep, nothing is rendered. Using fractions of FLT_MAX also 63 63 // result in nothing being rendered. 64 // INT_MAX is almost correct, but there seems to be some number wrapping occur ing making the fill64 // INT_MAX is almost correct, but there seems to be some number wrapping occurring making the fill 65 65 // pattern is not filled correctly. 66 66 // To make error of floating point less than 0.5, we use the half of the number of mantissa of float (1 << 22). -
trunk/WebCore/platform/graphics/mac/ComplexTextController.cpp
r52067 r53809 114 114 hitGlyphEnd = max<CFIndex>(hitGlyphStart, j > 0 ? complexTextRun.indexAt(j - 1) : complexTextRun.stringLength()); 115 115 116 // FIXME: Instead of dividing the glyph's advance equ ially between the characters, this116 // FIXME: Instead of dividing the glyph's advance equally between the characters, this 117 117 // could use the glyph's "ligature carets". However, there is no Core Text API to get the 118 118 // ligature carets. -
trunk/WebCore/platform/graphics/mac/GraphicsLayerCA.h
r53779 r53809 318 318 void repaintLayerDirtyRects(); 319 319 320 RetainPtr<WebLayer> m_layer; 321 RetainPtr<CALayer> m_structuralLayer; // A layer used for structual reasons, like preserves-3d or replica-flattening. Is the parent of m_layer.322 RetainPtr<CALayer> m_contentsLayer; 320 RetainPtr<WebLayer> m_layer; // The main layer 321 RetainPtr<CALayer> m_structuralLayer; // A layer used for structural reasons, like preserves-3d or replica-flattening. Is the parent of m_layer. 322 RetainPtr<CALayer> m_contentsLayer; // A layer used for inner content, like image and video 323 323 324 324 // References to clones of our layers, for replicated layers. -
trunk/WebCore/platform/graphics/mac/GraphicsLayerCA.mm
r53779 r53809 1212 1212 if (purpose == NoStructuralLayer) { 1213 1213 if (m_structuralLayer) { 1214 // Re lace the transformLayer in the parent with this layer.1214 // Replace the transformLayer in the parent with this layer. 1215 1215 [m_layer.get() removeFromSuperlayer]; 1216 1216 [[m_structuralLayer.get() superlayer] replaceSublayer:m_structuralLayer.get() with:m_layer.get()]; -
trunk/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm
r53792 r53809 657 657 [m_qtMovie.get() setCurrentTime:qttime]; 658 658 659 // restore playback only if not at end, othe wise QTMovie will loop659 // restore playback only if not at end, otherwise QTMovie will loop 660 660 float timeAfterSeek = currentTime(); 661 661 if (oldRate && timeAfterSeek < duration()) … … 767 767 #if USE(ACCELERATED_COMPOSITING) && (!defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)) 768 768 if (closedCaptionsVisible && m_qtVideoLayer) { 769 // Captions will be rendered upside ddown unless we flag the movie as flipped (again). See <rdar://7408440>.769 // Captions will be rendered upside down unless we flag the movie as flipped (again). See <rdar://7408440>. 770 770 [m_qtVideoLayer.get() setGeometryFlipped:YES]; 771 771 } … … 1082 1082 // When using a QTMovieLayer return true as soon as the movie reaches QTMovieLoadStatePlayable 1083 1083 // because although we don't *know* when the first frame has decoded, by the time we get and 1084 // process the notifica iton a frame should have propagated the VisualContext and been set on1084 // process the notification a frame should have propagated the VisualContext and been set on 1085 1085 // the layer. 1086 1086 if (currentRenderingMode() == MediaRenderingMovieLayer) -
trunk/WebCore/platform/mac/PasteboardMac.mm
r53442 r53809 137 137 { 138 138 if (!WebArchivePboardType) 139 Pasteboard::generalPasteboard(); // Initiali ses pasteboard types139 Pasteboard::generalPasteboard(); // Initializes pasteboard types. 140 140 ASSERT(selectedRange); 141 141 … … 207 207 { 208 208 if (!WebArchivePboardType) 209 Pasteboard::generalPasteboard(); // Initiali ses pasteboard types209 Pasteboard::generalPasteboard(); // Initializes pasteboard types. 210 210 211 211 NSArray *types = [NSArray arrayWithObject:NSStringPboardType]; … … 219 219 { 220 220 if (!WebArchivePboardType) 221 Pasteboard::generalPasteboard(); // Initiali ses pasteboard types221 Pasteboard::generalPasteboard(); // Initializes pasteboard types. 222 222 223 223 if (!types) { -
trunk/WebCore/platform/text/TextCodecICU.cpp
r44096 r53809 88 88 UErrorCode error = U_ZERO_ERROR; 89 89 // Try MIME before trying IANA to pick up commonly used names like 90 // 'EUC-JP' instead of horrend eously long names like90 // 'EUC-JP' instead of horrendously long names like 91 91 // 'Extended_UNIX_Code_Packed_Format_for_Japanese'. 92 92 const char* standardName = ucnv_getStandardName(name, "MIME", &error); -
trunk/WebCore/platform/text/TextEncodingDetectorICU.cpp
r42027 r53809 70 70 // 2. 'Emulate' Firefox/IE's non-Universal detectors (e.g. 71 71 // Chinese, Japanese, Russian, Korean and Hebrew) by picking the 72 // encoding with a highest confidence among the dete tctor-specific72 // encoding with a highest confidence among the detector-specific 73 73 // limited set of candidate encodings. 74 74 // Below is a partial implementation of the first part of what's outlined -
trunk/WebCore/rendering/AutoTableLayout.cpp
r46647 r53809 383 383 tMaxWidth = max(tMaxWidth, spanMax * 100 * percentScaleFactor / w.rawValue()); 384 384 385 // all non percent columns in the span get percent v laues to sum up correctly.385 // all non percent columns in the span get percent values to sum up correctly. 386 386 int percentMissing = w.rawValue() - totalPercent; 387 387 float totalWidth = 0; … … 665 665 } 666 666 667 // if we have overallocated, reduce every cell according to the difference between desired width and minwidth668 // this seems to produce to the pixel exa xt results with IE. Wonder is some of this also holds for width distributing.667 // If we have overallocated, reduce every cell according to the difference between desired width and minwidth 668 // this seems to produce to the pixel exact results with IE. Wonder is some of this also holds for width distributing. 669 669 if (available < 0) { 670 670 // Need to reduce cells with the following prioritization: -
trunk/WebCore/rendering/RenderBox.cpp
r53663 r53809 1941 1941 { 1942 1942 // 'left' and 'right' cannot both be 'auto' because one would of been 1943 // converted to the static pos tion already1943 // converted to the static position already 1944 1944 ASSERT(!(left.isAuto() && right.isAuto())); 1945 1945 … … 1975 1975 // Both margins auto, solve for equality 1976 1976 if (availableSpace >= 0) { 1977 marginLeftValue = availableSpace / 2; // split the dif erence1977 marginLeftValue = availableSpace / 2; // split the difference 1978 1978 marginRightValue = availableSpace - marginLeftValue; // account for odd valued differences 1979 1979 } else { … … 2260 2260 // Both margins auto, solve for equality 2261 2261 // NOTE: This may result in negative values. 2262 marginTopValue = availableSpace / 2; // split the dif erence2262 marginTopValue = availableSpace / 2; // split the difference 2263 2263 marginBottomValue = availableSpace - marginTopValue; // account for odd valued differences 2264 2264 } else if (marginTop.isAuto()) { … … 2338 2338 { 2339 2339 // The following is based off of the W3C Working Draft from April 11, 2006 of 2340 // CSS 2.1: Section 10.3.8 "Absolut ly positioned, replaced elements"2340 // CSS 2.1: Section 10.3.8 "Absolutely positioned, replaced elements" 2341 2341 // <http://www.w3.org/TR/2005/WD-CSS21-20050613/visudet.html#abs-replaced-width> 2342 2342 // (block-style-comments in this function correspond to text from the spec and … … 2429 2429 int difference = availableSpace - (leftValue + rightValue); 2430 2430 if (difference > 0) { 2431 m_marginLeft = difference / 2; // split the dif erence2431 m_marginLeft = difference / 2; // split the difference 2432 2432 m_marginRight = difference - m_marginLeft; // account for odd valued differences 2433 2433 } else { … … 2516 2516 { 2517 2517 // The following is based off of the W3C Working Draft from April 11, 2006 of 2518 // CSS 2.1: Section 10.6.5 "Absolut ly positioned, replaced elements"2518 // CSS 2.1: Section 10.6.5 "Absolutely positioned, replaced elements" 2519 2519 // <http://www.w3.org/TR/2005/WD-CSS21-20050613/visudet.html#abs-replaced-height> 2520 2520 // (block-style-comments in this function correspond to text from the spec and … … 2580 2580 2581 2581 if (marginTop.isAuto() && marginBottom.isAuto()) { 2582 // 'top' and 'bottom' cannot be 'auto' due to step 2 and 3 combin ded.2582 // 'top' and 'bottom' cannot be 'auto' due to step 2 and 3 combined. 2583 2583 ASSERT(!(top.isAuto() || bottom.isAuto())); 2584 2584 -
trunk/WebCore/rendering/RenderLayer.cpp
r53742 r53809 1156 1156 } 1157 1157 } else if (renderer()->view()->frameView()) { 1158 // If we are here, we were called on a renderer that can be program atically scrolled, but doesn't1158 // If we are here, we were called on a renderer that can be programmatically scrolled, but doesn't 1159 1159 // have an overflow clip. Which means that it is a document node that can be scrolled. 1160 1160 renderer()->view()->frameView()->scrollBy(IntSize(xDelta, yDelta)); … … 2276 2276 // is done by passing a nil paintingRoot down to our renderer (as if no paintingRoot was ever set). 2277 2277 // Else, our renderer tree may or may not contain the painting root, so we pass that root along 2278 // so it will be tested against as we de cend through the renderers.2278 // so it will be tested against as we descend through the renderers. 2279 2279 RenderObject* paintingRootForRenderer = 0; 2280 2280 if (paintingRoot && !renderer()->isDescendantOf(paintingRoot)) … … 2646 2646 // Next we want to see if the mouse pos is inside the child RenderObjects of the layer. 2647 2647 if (fgRect.contains(hitTestPoint) && isSelfPaintingLayer()) { 2648 // Hit test with a temporary HitTestResult, because we only lwant to commit to 'result' if we know we're frontmost.2648 // Hit test with a temporary HitTestResult, because we only want to commit to 'result' if we know we're frontmost. 2649 2649 HitTestResult tempResult(result.point()); 2650 2650 if (hitTestContents(request, tempResult, layerBounds, hitTestPoint, HitTestDescendants) && -
trunk/WebCore/rendering/RenderObject.cpp
r53797 r53809 1961 1961 // If this renderer is being autoscrolled, stop the autoscroll timer 1962 1962 1963 // FIXME: RenderObject::destroy should not get called with a render ar whose document1963 // FIXME: RenderObject::destroy should not get called with a renderer whose document 1964 1964 // has a null frame, so we assert this. However, we don't want release builds to crash which is why we 1965 1965 // check that the frame is not null. -
trunk/WebCore/rendering/RenderTextControl.cpp
r52632 r53809 196 196 } 197 197 198 // We set m_lastChangeWasUserEdit to false since this change was not explic ty made by the user (say, via typing on the keyboard), see <rdar://problem/5359921>.198 // We set m_lastChangeWasUserEdit to false since this change was not explicitly made by the user (say, via typing on the keyboard), see <rdar://problem/5359921>. 199 199 m_lastChangeWasUserEdit = false; 200 200 } -
trunk/WebCore/rendering/RenderTheme.cpp
r52432 r53809 598 598 bool RenderTheme::stateChanged(RenderObject* o, ControlState state) const 599 599 { 600 // Default implementation assumes the controls don t respond to changes in :hover state600 // Default implementation assumes the controls don't respond to changes in :hover state 601 601 if (state == HoverState && !supportsHover(o->style())) 602 602 return false; -
trunk/WebCore/rendering/SVGRenderSupport.cpp
r53300 r53809 70 70 { 71 71 ASSERT(!fixed); // We should have no fixed content in the SVG rendering tree. 72 ASSERT(useTransforms); // mapping a point through SVG w/o respecting trasnforms is useless.72 ASSERT(useTransforms); // Mapping a point through SVG w/o respecting transforms is useless. 73 73 transformState.applyTransform(object->localToParentTransform()); 74 74 object->parent()->mapLocalToContainer(repaintContainer, fixed, useTransforms, transformState); -
trunk/WebCore/rendering/SVGRootInlineBox.cpp
r52904 r53809 1423 1423 ASSERT(!info.chunk.boxes.isEmpty()); 1424 1424 1425 // Walk string to find out new chunk positions, if exist ant1425 // Walk string to find out new chunk positions, if existent 1426 1426 for (unsigned i = 0; i < length; ++i) { 1427 1427 ASSERT(info.it != svgChars.end()); -
trunk/WebCore/rendering/TransformState.cpp
r42174 r53809 116 116 117 117 // We could throw away m_accumulatedTransform if we wanted to here, but that 118 // would cause thrash when traversing hierar achies with alternating118 // would cause thrash when traversing hierarchies with alternating 119 119 // preserve-3d and flat elements. 120 120 if (m_accumulatedTransform)
Note: See TracChangeset
for help on using the changeset viewer.