Changeset 53834 in webkit


Ignore:
Timestamp:
Jan 25, 2010 5:24:04 PM (14 years ago)
Author:
sfalken@apple.com
Message:

2010-01-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Simon Fraser.

A WebGeolocationControllerClient is leaked for every WebView
​https://bugs.webkit.org/show_bug.cgi?id=34145

  • WebCoreSupport/WebGeolocationControllerClient.cpp: (WebGeolocationControllerClient::geolocationDestroyed): Added.
  • WebCoreSupport/WebGeolocationControllerClient.h:

2010-01-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Simon Fraser.

A WebGeolocationControllerClient is leaked for every WebView
​https://bugs.webkit.org/show_bug.cgi?id=34145

  • WebCoreSupport/WebGeolocationControllerClient.h:
  • WebCoreSupport/WebGeolocationControllerClient.mm: (WebGeolocationControllerClient::geolocationDestroyed):

2010-01-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Simon Fraser.

A WebGeolocationControllerClient is leaked for every WebView
​https://bugs.webkit.org/show_bug.cgi?id=34145

  • page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
  • page/GeolocationControllerClient.h:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r53814 r53834  
     12010-01-25  Steve Falkenburg  <sfalken@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        A WebGeolocationControllerClient is leaked for every WebView
     6        https://bugs.webkit.org/show_bug.cgi?id=34145
     7
     8        * page/GeolocationController.cpp:
     9        (WebCore::GeolocationController::~GeolocationController):
     10        * page/GeolocationControllerClient.h:
     11
    1122010-01-25  Chris Marrin  <cmarrin@apple.com>
    213

  • trunk/WebCore/page/GeolocationController.cpp

    r53582 r53834  
    4141GeolocationController::~GeolocationController()
    4242{
     43    m_client->geolocationDestroyed();
    4344}
    4445

  • trunk/WebCore/page/GeolocationControllerClient.h

    r52103 r53834  
    3333class GeolocationControllerClient {
    3434public:
     35    virtual void geolocationDestroyed() = 0;
     36
    3537    virtual void startUpdating() = 0;
    3638    virtual void stopUpdating() = 0;

  • trunk/WebKit/mac/ChangeLog

    r53746 r53834  
     12010-01-25  Steve Falkenburg  <sfalken@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        A WebGeolocationControllerClient is leaked for every WebView
     6        https://bugs.webkit.org/show_bug.cgi?id=34145
     7
     8        * WebCoreSupport/WebGeolocationControllerClient.h:
     9        * WebCoreSupport/WebGeolocationControllerClient.mm:
     10        (WebGeolocationControllerClient::geolocationDestroyed):
     11
    1122010-01-22  Steve Falkenburg  <sfalken@apple.com>
    213

  • trunk/WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h

    r52368 r53834  
    3737    WebView *webView() { return m_webView; }
    3838
     39    void geolocationDestroyed();
    3940    void startUpdating();
    4041    void stopUpdating();

  • trunk/WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm

    r52368 r53834  
    3636}
    3737
     38void WebGeolocationControllerClient::geolocationDestroyed()
     39{
     40    delete this;
     41}
     42
    3843void WebGeolocationControllerClient::startUpdating()
    3944{

  • trunk/WebKit/win/ChangeLog

    r53773 r53834  
     12010-01-25  Steve Falkenburg  <sfalken@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        A WebGeolocationControllerClient is leaked for every WebView
     6        https://bugs.webkit.org/show_bug.cgi?id=34145
     7
     8        * WebCoreSupport/WebGeolocationControllerClient.cpp:
     9        (WebGeolocationControllerClient::geolocationDestroyed): Added.
     10        * WebCoreSupport/WebGeolocationControllerClient.h:
     11
    1122010-01-23  Dan Bernstein  <mitz@apple.com>
    213

  • trunk/WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp

    r53202 r53834  
    3838}
    3939
     40void WebGeolocationControllerClient::geolocationDestroyed()
     41{
     42    delete this;
     43}
     44
    4045void WebGeolocationControllerClient::startUpdating()
    4146{

  • trunk/WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h

    r53165 r53834  
    4040    WebGeolocationControllerClient(WebView*);
    4141
     42    virtual void geolocationDestroyed();
    4243    virtual void startUpdating();
    4344    virtual void stopUpdating();
Note: See TracChangeset for help on using the changeset viewer.