Changeset 53917 in webkit

Timestamp:

Jan 27, 2010 3:43:55 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-27 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Eric Seidel.

Fix a bug where dispatchDocumentElementAvailable was fired for fragment parsing on XML documents.
​https://bugs.webkit.org/show_bug.cgi?id=33920

• userscripts/resources: Added.
• userscripts/resources/blank.xhtml: Added.
• userscripts/script-not-run-for-fragments-expected.txt: Added.
• userscripts/script-not-run-for-fragments.html: Added.
• userscripts/script-run-at-start-expected.txt: Added.
• userscripts/script-run-at-start.html: Added.

2010-01-27 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Eric Seidel.

Fix a bug where dispatchDocumentElementAvailable was fired for fragment parsing on XML documents.
​https://bugs.webkit.org/show_bug.cgi?id=33920

Tests: userscripts/script-not-run-for-fragments.html

userscripts/script-run-at-start.html

• dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/userscripts/resources (added)
• LayoutTests/userscripts/resources/blank.xhtml (added)
• LayoutTests/userscripts/script-not-run-for-fragments-expected.txt (added)
• LayoutTests/userscripts/script-not-run-for-fragments.html (added)
• LayoutTests/userscripts/script-run-at-start-expected.txt (added)
• LayoutTests/userscripts/script-run-at-start.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/XMLTokenizerLibxml2.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-01-27  Matt Perry  <mpcomplete@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Fix a bug where dispatchDocumentElementAvailable was fired for fragment parsing on XML documents.
+        https://bugs.webkit.org/show_bug.cgi?id=33920
+
+        * userscripts/resources: Added.
+        * userscripts/resources/blank.xhtml: Added.
+        * userscripts/script-not-run-for-fragments-expected.txt: Added.
+        * userscripts/script-not-run-for-fragments.html: Added.
+        * userscripts/script-run-at-start-expected.txt: Added.
+        * userscripts/script-run-at-start.html: Added.
+
 2010-01-27  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-01-27  Matt Perry  <mpcomplete@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Fix a bug where dispatchDocumentElementAvailable was fired for fragment parsing on XML documents.
+        https://bugs.webkit.org/show_bug.cgi?id=33920
+
+        Tests: userscripts/script-not-run-for-fragments.html
+               userscripts/script-run-at-start.html
+
+        * dom/XMLTokenizerLibxml2.cpp:
+        (WebCore::XMLTokenizer::startElementNs):
+
 2010-01-27  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/WebCore/dom/XMLTokenizerLibxml2.cpp

@@ -814 +814 @@
         newElement->attach();
 
-    if (isFirstElement && m_doc->frame())
+    if (!m_parsingFragment && isFirstElement && m_doc->frame())
         m_doc->frame()->loader()->dispatchDocumentElementAvailable();
 }