Changeset 53946 in webkit

Timestamp:

Jan 27, 2010 12:00:13 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-27 Mads Ager <​ager@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Support getting integer-named properties using indexing notation on document object
​https://bugs.webkit.org/show_bug.cgi?id=34211

• fast/dom/HTMLDocument/get-iframe-with-integer-name-expected.txt: Added.
• fast/dom/HTMLDocument/get-iframe-with-integer-name.html: Added.

2010-01-27 Mads Ager <​ager@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Support getting integer-named properties using indexing notation on document object
​https://bugs.webkit.org/show_bug.cgi?id=34211

Add indexed property getter to HTMLDocument to support getting
elements with integer names using indexing notation on document.

Test: fast/dom/HTMLDocument/get-iframe-with-integer-name.html

• bindings/scripts/CodeGeneratorV8.pm:
• bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::indexedPropertyGetter):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/HTMLDocument/get-iframe-with-integer-name-expected.txt (added)
• LayoutTests/fast/dom/HTMLDocument/get-iframe-with-integer-name.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/scripts/CodeGeneratorV8.pm (modified) (2 diffs)
• WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-01-27  Mads Ager  <ager@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [V8] Support getting integer-named properties using indexing notation on document object
+        https://bugs.webkit.org/show_bug.cgi?id=34211
+
+        * fast/dom/HTMLDocument/get-iframe-with-integer-name-expected.txt: Added.
+        * fast/dom/HTMLDocument/get-iframe-with-integer-name.html: Added.
+
 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-01-27  Mads Ager  <ager@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [V8] Support getting integer-named properties using indexing notation on document object
+        https://bugs.webkit.org/show_bug.cgi?id=34211
+
+        Add indexed property getter to HTMLDocument to support getting
+        elements with integer names using indexing notation on document.
+
+        Test: fast/dom/HTMLDocument/get-iframe-with-integer-name.html
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
+        (WebCore::V8HTMLDocument::indexedPropertyGetter):
+
 2010-01-27  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -430 +430 @@
     "Storage" => 1,
     "HTMLAppletElement" => 1,
+    "HTMLDocument" => 1,
     "HTMLEmbedElement" => 1,
     "HTMLObjectElement" => 1
@@ -1306 +1307 @@
     if ($isSpecialCase) {
         $hasGetter = 1;
-        $hasCustomSetter = 1;
+        if ($dataNode->extendedAttributes->{"DelegatingPutFunction"}) {
+            $hasCustomSetter = 1;
+        }
     }
 

trunk/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp

@@ -100 +100 @@
 }
 
+v8::Handle<v8::Value> V8HTMLDocument::indexedPropertyGetter(uint32_t index, const v8::AccessorInfo &info) 
+{
+    INC_STATS("DOM.HTMLDocument.IndexedPropertyGetter");
+    v8::Local<v8::Integer> indexV8 = v8::Integer::NewFromUnsigned(index);
+    return namedPropertyGetter(indexV8->ToString(), info);
+}
+
 // HTMLDocument ----------------------------------------------------------------