Changeset 53976 in webkit

Timestamp:

Jan 28, 2010 12:12:32 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-28 Joe Mason <​jmason@rim.com>

Reviewed by Adam Barth.

Limit login retries to 5
​https://bugs.webkit.org/show_bug.cgi?id=34193

• Scripts/webkitpy/bugzilla.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/bugzilla.py (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-28  Joe Mason  <jmason@rim.com>
+
+        Reviewed by Adam Barth.
+
+        Limit login retries to 5
+        https://bugs.webkit.org/show_bug.cgi?id=34193
+
+        * Scripts/webkitpy/bugzilla.py:
+
 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/bugzilla.py

@@ -468 +468 @@
             return
 
+        attempts = 0
         while not self.authenticated:
+            attempts += 1
             (username, password) = Credentials(
                 self.bug_server_host, git_prefix="bugzilla").read_credentials()
@@ -484 +486 @@
             # "invalid" assume it's the login failure page.
             if match and re.search("Invalid", match.group(1), re.IGNORECASE):
-                log("Bugzilla login failed: %s" % match.group(1))
+                errorMessage = "Bugzilla login failed: %s" % match.group(1)
+                # raise an exception only if this was the last attempt
+                if attempts < 5:
+                    log(errorMessage)
+                else:
+                    raise Exception(errorMessage)
             else:
                 self.authenticated = True