Changeset 54048 in webkit

Timestamp:

Jan 28, 2010 11:42:05 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-28 Nicholas Young <​nicholas.young@nokia.com>

Reviewed by Eric Carlson.

Prefer provided video element width/height properties to hard coded
defaults for intrinsic size when natural video size is unavailable.
​https://bugs.webkit.org/show_bug.cgi?id=34302

No new tests needed.

• rendering/RenderVideo.cpp: Attempt to use width/height properties (WebCore::RenderVideo::RenderVideo):
• rendering/RenderVideo.h: More appropriate constructor signature

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderVideo.cpp (modified) (2 diffs)
• rendering/RenderVideo.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-01-28  Nicholas Young  <nicholas.young@nokia.com>
+
+        Reviewed by Eric Carlson.
+
+        Prefer provided video element width/height properties to hard coded
+        defaults for intrinsic size when natural video size is unavailable.
+        https://bugs.webkit.org/show_bug.cgi?id=34302
+
+        No new tests needed.
+
+        * rendering/RenderVideo.cpp: Attempt to use width/height properties
+        (WebCore::RenderVideo::RenderVideo):
+        * rendering/RenderVideo.h: More appropriate constructor signature
+
 2010-01-28  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/rendering/RenderVideo.cpp

@@ -51 +51 @@
 static const int cDefaultHeight = 150;
 
-RenderVideo::RenderVideo(HTMLMediaElement* video)
+RenderVideo::RenderVideo(HTMLVideoElement* video)
     : RenderMedia(video)
 {
@@ -57 +57 @@
         setIntrinsicSize(video->player()->naturalSize());
     else {
-        // Video in standalone media documents should not use the default 300x150
-        // size since they also have audio thrown at them. By setting the intrinsic
-        // size to 300x1 the video will resize itself in these cases, and audio will
-        // have the correct height (it needs to be > 0 for controls to render properly).
-        if (video->ownerDocument() && video->ownerDocument()->isMediaDocument())
+        // When the natural size of the video is unavailable, we use the provided
+        // width and height attributes of the video element as the intrinsic size until
+        // better values become available. If these attributes are not set, we fall back
+        // to a default video size (300x150).
+        if (video->hasAttribute(widthAttr) && video->hasAttribute(heightAttr))
+            setIntrinsicSize(IntSize(video->width(), video->height()));
+        else if (video->ownerDocument() && video->ownerDocument()->isMediaDocument()) {
+            // Video in standalone media documents should not use the default 300x150
+            // size since they also have audio thrown at them. By setting the intrinsic
+            // size to 300x1 the video will resize itself in these cases, and audio will
+            // have the correct height (it needs to be > 0 for controls to render properly).
             setIntrinsicSize(IntSize(cDefaultWidth, 1));
+        }
         else
             setIntrinsicSize(IntSize(cDefaultWidth, cDefaultHeight));

trunk/WebCore/rendering/RenderVideo.h

@@ -41 +41 @@
 class RenderVideo : public RenderMedia {
 public:
-    RenderVideo(HTMLMediaElement*);
+    RenderVideo(HTMLVideoElement*);
     virtual ~RenderVideo();