Changeset 54071 in webkit

Timestamp:

Jan 29, 2010 10:32:33 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-29 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

Add gdb helper methods for Ranges like we have for VisibleSelections.
​https://bugs.webkit.org/show_bug.cgi?id=34308

No new tests, these are only for debugging.

• dom/Position.cpp: (WebCore::Position::showTreeForThis):
• dom/Range.cpp: (showTree):
• dom/Range.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Position.cpp (modified) (1 diff)
• dom/Range.cpp (modified) (1 diff)
• dom/Range.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-01-29  Tony Chang  <tony@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Add gdb helper methods for Ranges like we have for VisibleSelections.
+        https://bugs.webkit.org/show_bug.cgi?id=34308
+
+        No new tests, these are only for debugging.
+
+        * dom/Position.cpp:
+        (WebCore::Position::showTreeForThis):
+        * dom/Range.cpp:
+        (showTree):
+        * dom/Range.h:
+
 2010-01-29  Drew Wilson  <atwilson@chromium.org>
 

trunk/WebCore/dom/Position.cpp

@@ -1177 +1177 @@
 void Position::showTreeForThis() const
 {
-    if (node())
+    if (node()) {
         node()->showTreeForThis();
+        fprintf(stderr, "offset: %d\n", m_offset);
+    }
 }
 

trunk/WebCore/dom/Range.cpp

@@ -1931 +1931 @@
 
 } // namespace WebCore
+
+#ifndef NDEBUG
+
+void showTree(const WebCore::Range* range)
+{
+    if (range && range->boundaryPointsValid()) {
+        WebCore::Position start = range->startPosition();
+        WebCore::Position end = range->endPosition();
+        start.node()->showTreeAndMark(start.node(), "S", end.node(), "E");
+        fprintf(stderr, "start offset: %d, end offset: %d\n", start.deprecatedEditingOffset(), end.deprecatedEditingOffset());
+    }
+}
+
+#endif

trunk/WebCore/dom/Range.h

@@ -159 +159 @@
 } // namespace
 
+#ifndef NDEBUG
+// Outside the WebCore namespace for ease of invocation from gdb.
+void showTree(const WebCore::Range*);
 #endif
+
+#endif