Changeset 54108 in webkit


Ignore:
Timestamp:
Jan 30, 2010 11:38:52 PM (14 years ago)
Author:
yurys@chromium.org
Message:

2010-01-31 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Make ScriptState destructor protected since all non-empty
ScriptStates are managed by GC. Remove obsolete constructor.

​https://bugs.webkit.org/show_bug.cgi?id=34266

  • bindings/v8/ScriptState.cpp:
  • bindings/v8/ScriptState.h:
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r54107 r54108  
     12010-01-31  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Make ScriptState destructor protected since all non-empty
     6        ScriptStates are managed by GC. Remove obsolete constructor.
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=34266
     9
     10        * bindings/v8/ScriptState.cpp:
     11        * bindings/v8/ScriptState.h:
     12
    1132010-01-30  Simon Fraser  <simon.fraser@apple.com>
    214

  • trunk/WebCore/bindings/v8/ScriptState.cpp

    r54051 r54108  
    4242
    4343namespace WebCore {
    44 
    45 ScriptState::ScriptState(Frame*, v8::Handle<v8::Context> context)
    46     : m_context(v8::Persistent<v8::Context>::New(context))
    47 {
    48 }
    4944
    5045ScriptState::ScriptState(v8::Handle<v8::Context> context)

  • trunk/WebCore/bindings/v8/ScriptState.h

    r54051 r54108  
    4545    class ScriptState : public Noncopyable {
    4646    public:
    47         // FIXME: This destructor will become private shortly.
    48         ~ScriptState();
    49         // FIXME: This constructor will go away shortly.
    50         ScriptState(Frame*, v8::Handle<v8::Context>);
    51 
    5247        bool hadException() { return !m_exception.IsEmpty(); }
    5348        void setException(v8::Local<v8::Value> exception)
    … …  
    6762    protected:
    6863        ScriptState() { }
     64        ~ScriptState();
    6965
    7066    private:
Note: See TracChangeset for help on using the changeset viewer.