Changeset 54122 in webkit


Ignore:
Timestamp:
Jan 31, 2010 6:37:49 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-01-31 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Limit the scope of packing alignment to avoid MSVC C4103 warning.
https://bugs.webkit.org/show_bug.cgi?id=34390

Use pack(push, 16) and pack(pop) to limit the scope of packing
alignment change.

  • bindings/js/JSSVGPODTypeWrapper.h:
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r54120 r54122  
     12010-01-31  Kwang Yul Seo  <skyul@company100.net>
     2
     3        Reviewed by Darin Adler.
     4
     5        Limit the scope of packing alignment to avoid MSVC C4103 warning.
     6        https://bugs.webkit.org/show_bug.cgi?id=34390
     7
     8        Use pack(push, 16) and pack(pop) to limit the scope of packing
     9        alignment change.
     10
     11        * bindings/js/JSSVGPODTypeWrapper.h:
     12
    1132010-01-31  Kent Tamura  <tkent@chromium.org>
    214
  • trunk/WebCore/bindings/js/JSSVGPODTypeWrapper.h

    r53879 r54122  
    7272// greater than or equal to that to avoid an alignment warning (C4121). 16 is
    7373// the next-largest size allowed for packing, so we use that.
    74 #pragma pack(16)
     74#pragma pack(push, 16)
    7575#endif
    7676template<typename PODType, typename PODTypeCreator>
     
    114114    SetterMethod m_setter;
    115115};
     116#if COMPILER(MSVC)
     117#pragma pack(pop)
     118#endif
    116119
    117120// Represents a JS wrapper object for SVG POD types (not for SVGAnimated* classes). Any modification to the SVG POD
     
    176179// greater than or equal to that to avoid an alignment warning (C4121). 16 is
    177180// the next-largest size allowed for packing, so we use that.
    178 #pragma pack(16)
     181#pragma pack(push, 16)
    179182#endif
    180183template<typename PODType, typename ParentType>
     
    311314    SetterMethod setter;
    312315};
     316#if COMPILER(MSVC)
     317#pragma pack(pop)
     318#endif
    313319
    314320template<typename PODType, typename PODTypeCreator>
Note: See TracChangeset for help on using the changeset viewer.