Changeset 54212 in webkit

Timestamp:

Feb 2, 2010 12:25:30 AM (14 years ago)

Author:

tkent@chromium.org

Message:

2010-02-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Should not select a word on right-click.
​https://bugs.webkit.org/show_bug.cgi?id=33364

For non-Mac platforms, do not select a word around the caret when
a context menu is opening. This behavior is not common in non-Mac
platforms, and it prevents pasting with a context menu.

In order that the spell checker works without the selection, we
introduce WebFrame::selectWordAroundCaret(). We can replace a word
around the caret with selectWordAroundCaret() + replaceSelection().

• public/WebFrame.h: Add pure selectWordAroundCaret() declaration.
• src/ContextMenuClientImpl.cpp: (WebKit::selectMisspelledWord): Move word-selection code to WebFrameImpl::selectWordAroundPosition(), and clear the selection on non-Mac.
• src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectWordAroundPosition): (WebKit::WebFrameImpl::selectWordAroundCaret):
• src/WebFrameImpl.h: Add selectWordAroundCaret() declaration.

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebFrame.h (modified) (1 diff)
• src/ContextMenuClientImpl.cpp (modified) (2 diffs)
• src/WebFrameImpl.cpp (modified) (1 diff)
• src/WebFrameImpl.h (modified) (2 diffs)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-02-02  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        [Chromium] Should not select a word on right-click.
+        https://bugs.webkit.org/show_bug.cgi?id=33364
+
+        For non-Mac platforms, do not select a word around the caret when
+        a context menu is opening. This behavior is not common in non-Mac
+        platforms, and it prevents pasting with a context menu.
+
+        In order that the spell checker works without the selection, we
+        introduce WebFrame::selectWordAroundCaret(). We can replace a word
+        around the caret with selectWordAroundCaret() + replaceSelection().
+
+        * public/WebFrame.h: Add pure selectWordAroundCaret() declaration.
+        * src/ContextMenuClientImpl.cpp:
+        (WebKit::selectMisspelledWord): Move word-selection code to
+        WebFrameImpl::selectWordAroundPosition(), and clear the selection
+        on non-Mac.
+        * src/WebFrameImpl.cpp:
+        (WebKit::WebFrameImpl::selectWordAroundPosition):
+        (WebKit::WebFrameImpl::selectWordAroundCaret):
+        * src/WebFrameImpl.h: Add selectWordAroundCaret() declaration.
+
 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
 

trunk/WebKit/chromium/public/WebFrame.h

@@ -358 +358 @@
     virtual WebString selectionAsMarkup() const = 0;
 
+    // Expands the selection to a word around the caret and returns
+    // true. Does nothing and returns false if there is no caret or
+    // there is ranged selection.
+    virtual bool selectWordAroundCaret() = 0;
+
 
     // Printing ------------------------------------------------------------

trunk/WebKit/chromium/src/ContextMenuClientImpl.cpp

@@ -90 +90 @@
 // is to be evolked. This function also sets the word on which context menu
 // has been evoked to be the selected word, as required. This function changes
-// the selection only when there were no selected characters.
+// the selection only when there were no selected characters on OS X.
 static String selectMisspelledWord(const ContextMenu* defaultMenu, Frame* selectedFrame)
 {
@@ -111 +111 @@
         hitTestResult.localPoint()));
 
-    VisibleSelection selection;
-    if (pos.isNotNull()) {
-        selection = VisibleSelection(pos);
-        selection.expandUsingGranularity(WordGranularity);
-    }
-
-    if (selection.isRange())
-        selectedFrame->setSelectionGranularity(WordGranularity);
-
-    if (selectedFrame->shouldChangeSelection(selection))
-        selectedFrame->selection()->setSelection(selection);
-
+    if (pos.isNull())
+        return misspelledWord; // It is empty.
+
+    WebFrameImpl::selectWordAroundPosition(selectedFrame, pos);
     misspelledWord = selectedFrame->selectedText().stripWhiteSpace();
 
+#if OS(DARWIN)
     // If misspelled word is still empty, then that portion should not be
     // selected. Set the selection to that position only, and do not expand.
-    if (misspelledWord.isEmpty()) {
-        selection = VisibleSelection(pos);
-        selectedFrame->selection()->setSelection(selection);
-    }
-
+    if (misspelledWord.isEmpty())
+        selectedFrame->selection()->setSelection(VisibleSelection(pos));
+#else
+    // On non-Mac, right-click should not make a range selection in any case.
+    selectedFrame->selection()->setSelection(VisibleSelection(pos));
+#endif
     return misspelledWord;
 }

trunk/WebKit/chromium/src/WebFrameImpl.cpp

@@ -1078 +1078 @@
 }
 
+void WebFrameImpl::selectWordAroundPosition(Frame* frame, VisiblePosition pos)
+{
+    VisibleSelection selection(pos);
+    selection.expandUsingGranularity(WordGranularity);
+
+    if (selection.isRange())
+        frame->setSelectionGranularity(WordGranularity);
+
+    if (frame->shouldChangeSelection(selection))
+        frame->selection()->setSelection(selection);
+}
+
+bool WebFrameImpl::selectWordAroundCaret()
+{
+    SelectionController* controller = frame()->selection();
+    ASSERT(!controller->isNone());
+    if (controller->isNone() || controller->isRange())
+        return false;
+    selectWordAroundPosition(frame(), controller->selection().visibleStart());
+    return true;
+}
+
 int WebFrameImpl::printBegin(const WebSize& pageSize)
 {

trunk/WebKit/chromium/src/WebFrameImpl.h

@@ -142 +142 @@
     virtual WebString selectionAsText() const;
     virtual WebString selectionAsMarkup() const;
+    virtual bool selectWordAroundCaret();
     virtual int printBegin(const WebSize& pageSize);
     virtual float printPage(int pageToPrint, WebCanvas*);
@@ -220 +221 @@
     void dropClient() { m_client = 0; }
 
+    static void selectWordAroundPosition(WebCore::Frame*, WebCore::VisiblePosition);
+
 private:
     class DeferredScopeStringMatches;