Changeset 54272 in webkit

Timestamp:

Feb 2, 2010 9:22:13 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-02-02 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
​https://bugs.webkit.org/show_bug.cgi?id=34483

Add tests for datetime, datetime-local, month, time and week, and
merge existing tests into one test file.

• fast/forms/ValidityState-rangeOverflow-date-expected.txt: Removed.
• fast/forms/ValidityState-rangeOverflow-date.html: Removed.
• fast/forms/ValidityState-rangeOverflow-expected.txt: Added.
• fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
• fast/forms/ValidityState-rangeOverflow-number.html: Removed.
• fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
• fast/forms/ValidityState-rangeOverflow-range.html: Removed.
• fast/forms/ValidityState-rangeOverflow.html: Added.
• fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Removed.
• fast/forms/ValidityState-rangeUnderflow-date.html: Removed.
• fast/forms/ValidityState-rangeUnderflow-expected.txt: Added.
• fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
• fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
• fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
• fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
• fast/forms/ValidityState-rangeUnderflow.html: Added.
• fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Removed.
• fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
• fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
• fast/forms/script-tests/ValidityState-rangeOverflow.js: Added.
• fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Removed.
• fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
• fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
• fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added.

2010-02-02 James Robinson <​jamesr@chromium.org>

Reviewed by Dmitry Titov.

Add a null check for image, which might be NULL if tileSize is empty
​https://bugs.webkit.org/show_bug.cgi?id=34510

Test: fast/gradients/crash-on-1px-border.html

• rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/gradients/crash-on-1px-border-expected.txt (added)
• LayoutTests/fast/gradients/crash-on-1px-border.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderBoxModelObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ -35 +35 @@
         * fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added.
 
-2010-02-02  Fumitoshi Ukai  <ukai@chromium.org>
-
+2010-02-02  James Robinson  <jamesr@chromium.org>
+
+        Reviewed by Dmitry Titov.
+
+        Test that the combination of border-bottom:1px; and -webkit-gradient(linear) doesn't crash
+        https://bugs.webkit.org/show_bug.cgi?id=34510
+
+        * fast/gradients/crash-on-1px-border.html: Added.
+
+2010-02-02  Fumitoshi Ukai  <ukai@chromium.org> 
         Reviewed by Alexey Proskuryakov.
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-02-02  James Robinson  <jamesr@chromium.org>
+
+        Reviewed by Dmitry Titov.
+
+        Add a null check for image, which might be NULL if tileSize is empty
+        https://bugs.webkit.org/show_bug.cgi?id=34510
+
+        Test: fast/gradients/crash-on-1px-border.html
+
+        * rendering/RenderBoxModelObject.cpp:
+        (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
+
 2010-02-02  Kent Tamura  <tkent@chromium.org>
 

trunk/WebCore/rendering/RenderBoxModelObject.cpp

@@ -119 +119 @@
     // If the image is not a bitmap image, then none of this is relevant and we just paint at high
     // quality.
-    if (!image->isBitmapImage())
+    if (!image || !image->isBitmapImage())
         return false;