Changeset 54366 in webkit


Ignore:
Timestamp:
Feb 4, 2010 1:19:20 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-02-04 Steve Block <steveblock@google.com>

Reviewed by Nate Chapin.

Fix bug in V8 convertNPVariantToJValue when converting float and double types
https://bugs.webkit.org/show_bug.cgi?id=34593

No new tests, build fix only.

  • bridge/jni/v8/JNIUtilityPrivate.cpp: Modified. (JSC::Bindings::convertNPVariantToJValue): Modified. Use correct members of 'result' enum.
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r54364 r54366  
     12010-02-04  Steve Block  <steveblock@google.com>
     2
     3        Reviewed by Nate Chapin.
     4
     5        Fix bug in V8 convertNPVariantToJValue when converting float and double types
     6        https://bugs.webkit.org/show_bug.cgi?id=34593
     7
     8        No new tests, build fix only.
     9
     10        * bridge/jni/v8/JNIUtilityPrivate.cpp: Modified.
     11        (JSC::Bindings::convertNPVariantToJValue): Modified. Use correct members of 'result' enum.
     12
    1132010-02-04  Chris Guillory  <chris.guillory@google.com>
    214
  • trunk/WebCore/bridge/jni/v8/JNIUtilityPrivate.cpp

    r54171 r54366  
    135135        {
    136136            if (type == NPVariantType_Int32)
    137                 result.j = static_cast<jfloat>(NPVARIANT_TO_INT32(value));
     137                result.f = static_cast<jfloat>(NPVARIANT_TO_INT32(value));
    138138            else if (type == NPVariantType_Double)
    139                 result.j = static_cast<jfloat>(NPVARIANT_TO_DOUBLE(value));
     139                result.f = static_cast<jfloat>(NPVARIANT_TO_DOUBLE(value));
    140140            else
    141141                bzero(&result, sizeof(jvalue));
     
    146146        {
    147147            if (type == NPVariantType_Int32)
    148                 result.j = static_cast<jdouble>(NPVARIANT_TO_INT32(value));
     148                result.d = static_cast<jdouble>(NPVARIANT_TO_INT32(value));
    149149            else if (type == NPVariantType_Double)
    150                 result.j = static_cast<jdouble>(NPVARIANT_TO_DOUBLE(value));
     150                result.d = static_cast<jdouble>(NPVARIANT_TO_DOUBLE(value));
    151151            else
    152152                bzero(&result, sizeof(jvalue));
Note: See TracChangeset for help on using the changeset viewer.