Changeset 54417 in webkit


Ignore:
Timestamp:
Feb 5, 2010 4:05:37 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-02-05 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Enable JAVASCRIPT_DEBUGGER in chromium port.

​https://bugs.webkit.org/show_bug.cgi?id=34638

  • page/Console.cpp:
  • page/Console.h:
  • page/Console.idl:

2010-02-05 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Enable JAVASCRIPT_DEBUGGER in chromium port.

​https://bugs.webkit.org/show_bug.cgi?id=34638

  • features.gypi:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r54415 r54417  
     12010-02-05  Mikhail Naganov  <mnaganov@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Enable JAVASCRIPT_DEBUGGER in chromium port.
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=34638
     8
     9        * page/Console.cpp:
     10        * page/Console.h:
     11        * page/Console.idl:
     12
    1132010-02-05  Pavel Feldman  <pfeldman@chromium.org>
    214

  • trunk/WebCore/page/Console.cpp

    r54277 r54417  
    313313#endif
    314314
    315 // FIXME: "USE(V8)" and "USE(JSC)" below are temporary measures until JAVASCRIPT_DEBUGGER is
    316 // enabled when building Chromium.
    317 #if ENABLE(JAVASCRIPT_DEBUGGER) || USE(V8)
     315#if ENABLE(JAVASCRIPT_DEBUGGER)
    318316
    319317void Console::profile(const String& title, ScriptCallStack* callStack)

  • trunk/WebCore/page/Console.h

    r54277 r54417  
    3939namespace WebCore {
    4040
    41 // FIXME: "USE(V8)" and "USE(JSC)" below are temporary measures until JAVASCRIPT_DEBUGGER is
    42 // enabled when building Chromium.
    43 #if ENABLE(JAVASCRIPT_DEBUGGER) || USE(V8)
     41#if ENABLE(JAVASCRIPT_DEBUGGER)
    4442typedef Vector<RefPtr<ScriptProfile> > ProfilesArray;
    4543#endif
    … …  
    10098    String lastWMLErrorMessage() const;
    10199#endif
    102 #if ENABLE(JAVASCRIPT_DEBUGGER) || USE(V8)
     100#if ENABLE(JAVASCRIPT_DEBUGGER)
    103101    void profile(const String&, ScriptCallStack*);
    104102    void profileEnd(const String&, ScriptCallStack*);
    … …  
    123121
    124122    Frame* m_frame;
    125 #if ENABLE(JAVASCRIPT_DEBUGGER) || USE(V8)
     123#if ENABLE(JAVASCRIPT_DEBUGGER)
    126124    ProfilesArray m_profiles;
    127125#endif

  • trunk/WebCore/page/Console.idl

    r54277 r54417  
    5151#endif
    5252
    53 #if defined(ENABLE_JAVASCRIPT_DEBUGGER) && ENABLE_JAVASCRIPT_DEBUGGER || defined(V8_BINDING) && V8_BINDING
     53#if defined(ENABLE_JAVASCRIPT_DEBUGGER) && ENABLE_JAVASCRIPT_DEBUGGER
    5454        [CustomArgumentHandling] void profile(in [ConvertUndefinedOrNullToNullString] DOMString title);
    5555        [CustomArgumentHandling] void profileEnd(in [ConvertUndefinedOrNullToNullString] DOMString title);

  • trunk/WebKit/chromium/ChangeLog

    r54410 r54417  
     12010-02-05  Mikhail Naganov  <mnaganov@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Enable JAVASCRIPT_DEBUGGER in chromium port.
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=34638
     8
     9        * features.gypi:
     10
    1112010-02-04  Yaar Schnitman  <yaar@chromium.org>
    212

  • trunk/WebKit/chromium/features.gypi

    r54085 r54417  
    4848        'ENABLE_DOM_STORAGE=1',
    4949        'ENABLE_GEOLOCATION=1',
    50         'ENABLE_JAVASCRIPT_DEBUGGER=0',
    5150        'ENABLE_JSC_MULTIPLE_THREADS=0',
    5251        'ENABLE_ICONDATABASE=0',
Note: See TracChangeset for help on using the changeset viewer.