Changeset 54466 in webkit
- Timestamp:
- Feb 6, 2010 12:18:51 PM (14 years ago)
- Location:
- trunk
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r54465 r54466 1 2010-02-06 Dimitri Glazkov <dglazkov@chromium.org> 2 3 No review, rolling out r54364. 4 http://trac.webkit.org/changeset/54364 5 https://bugs.webkit.org/show_bug.cgi?id=34464 6 7 Introduced asserts in layout tests, needs more testing 8 locally. 9 10 * accessibility/chromium/AXObjectCacheChromium.cpp: 11 (WebCore::AXObjectCache::postPlatformNotification): 12 * page/chromium/ChromeClientChromium.h: 13 1 14 2010-02-06 Dimitri Glazkov <dglazkov@chromium.org> 2 15 -
trunk/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp
r54364 r54466 27 27 #include "config.h" 28 28 #include "AXObjectCache.h" 29 29 30 #include "AccessibilityObject.h" 30 #include "Chrome.h"31 #include "ChromeClientChromium.h"32 #include "FrameView.h"33 31 34 32 namespace WebCore { 35 36 static ChromeClientChromium* toChromeClientChromium(FrameView* view)37 {38 Page* page = view->frame() ? view->frame()->page() : 0;39 if (!page)40 return 0;41 42 return static_cast<ChromeClientChromium*>(page->chrome()->client());43 }44 33 45 34 void AXObjectCache::detachWrapper(AccessibilityObject* obj) … … 55 44 } 56 45 57 void AXObjectCache::postPlatformNotification(AccessibilityObject* obj, AXNotification notification)46 void AXObjectCache::postPlatformNotification(AccessibilityObject*, AXNotification) 58 47 { 59 if (!obj || !obj->documentFrameView() || notification != AXCheckedStateChanged)60 return;61 62 ChromeClientChromium* client = toChromeClientChromium(obj->documentFrameView());63 if (client)64 client->didChangeAccessibilityObjectState(obj);65 48 } 66 49 -
trunk/WebCore/page/chromium/ChromeClientChromium.h
r54364 r54466 36 36 37 37 namespace WebCore { 38 class IntRect; 39 class PopupContainer; 38 40 39 class AccessibilityObject; 40 class IntRect; 41 class PopupContainer; 42 43 // Contains Chromium-specific extensions to the ChromeClient. Only put 44 // things here that don't make sense for other ports. 45 class ChromeClientChromium : public ChromeClient { 46 public: 47 // Notifies the client of a new popup widget. The client should place 48 // and size the widget with the given bounds, relative to the screen. 49 // If handleExternal is true, then drawing and input handling for the 50 // popup will be handled by the external embedder. 51 virtual void popupOpened(PopupContainer* popupContainer, const IntRect& bounds, 52 bool focusOnShow, bool handleExternal) = 0; 53 54 // Notifies embedder that the state of an accessibility object has changed. 55 virtual void didChangeAccessibilityObjectState(AccessibilityObject*) = 0; 56 }; 41 // Contains Chromium-specific extensions to the ChromeClient. Only put 42 // things here that don't make sense for other ports. 43 class ChromeClientChromium : public ChromeClient { 44 public: 45 // Notifies the client of a new popup widget. The client should place 46 // and size the widget with the given bounds, relative to the screen. 47 // If handleExternal is true, then drawing and input handling for the 48 // popup will be handled by the external embedder. 49 virtual void popupOpened(PopupContainer* popupContainer, const IntRect& bounds, 50 bool focusOnShow, bool handleExternal) = 0; 51 }; 57 52 58 53 } // namespace WebCore -
trunk/WebKit/chromium/ChangeLog
r54458 r54466 1 2010-02-06 Dimitri Glazkov <dglazkov@chromium.org> 2 3 No review, rolling out r54364. 4 http://trac.webkit.org/changeset/54364 5 https://bugs.webkit.org/show_bug.cgi?id=34464 6 7 Introduced asserts in layout tests, needs more testing 8 locally. 9 10 * public/WebViewClient.h: 11 * src/ChromeClientImpl.cpp: 12 * src/ChromeClientImpl.h: 13 1 14 2010-02-05 James Hawkins <jhawkins@chromium.org> 2 15 -
trunk/WebKit/chromium/public/WebViewClient.h
r54364 r54466 253 253 virtual void focusAccessibilityObject(const WebAccessibilityObject&) { } 254 254 255 // Notifies embedder that the state of an accessibility object has changed.256 virtual void didChangeAccessibilityObjectState(const WebAccessibilityObject&) { }257 258 255 259 256 // Developer tools ----------------------------------------------------- -
trunk/WebKit/chromium/src/ChromeClientImpl.cpp
r54364 r54466 660 660 } 661 661 662 void ChromeClientImpl::didChangeAccessibilityObjectState(AccessibilityObject* obj)663 {664 // Alert assistive technology about the accessibility object state change665 if (obj)666 m_webView->client()->didChangeAccessibilityObjectState(WebAccessibilityObject(obj));667 }668 669 662 #if ENABLE(NOTIFICATIONS) 670 663 NotificationPresenter* ChromeClientImpl::notificationPresenter() const -
trunk/WebKit/chromium/src/ChromeClientImpl.h
r54364 r54466 35 35 36 36 namespace WebCore { 37 class AccessibilityObject;38 37 class HTMLParserQuirks; 39 38 class PopupContainer; … … 134 133 bool activatable, 135 134 bool handleExternally); 136 virtual void didChangeAccessibilityObjectState(WebCore::AccessibilityObject*);137 135 138 136 // ChromeClientImpl:
Note: See TracChangeset
for help on using the changeset viewer.