Changeset 54519 in webkit


Ignore:
Timestamp:
Feb 8, 2010 4:32:26 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-02-08 Charlie Reis <​creis@chromium.org>

Reviewed by Darin Adler.

onbeforeunload not called at window close + frame or iframe focused
​https://bugs.webkit.org/show_bug.cgi?id=27481

Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.

Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.

  • manual-tests/onbeforeunload-focused-iframe.html: Added.
  • manual-tests/resources/focused-iframe.html: Added.

2010-02-08 Charlie Reis <​creis@chromium.org>

Reviewed by Darin Adler.

onbeforeunload not called at window close + frame or iframe focused
​https://bugs.webkit.org/show_bug.cgi?id=27481
​http://code.google.com/p/chromium/issues/detail?id=32615
​http://code.google.com/p/chromium/issues/detail?id=17157

Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.

Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dispatchBeforeUnloadEvent):

2010-02-08 Charlie Reis <​creis@chromium.org>

Reviewed by Darin Adler.

onbeforeunload not called at window close + frame or iframe focused
​https://bugs.webkit.org/show_bug.cgi?id=27481

Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.

Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.

  • WebView.cpp: (WebView::shouldClose):
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r54517 r54519  
     12010-02-08  Charlie Reis  <creis@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        onbeforeunload not called at window close + frame or iframe focused
     6        https://bugs.webkit.org/show_bug.cgi?id=27481
     7       
     8        Chromium and WebKit on Windows will now fire beforeunload handlers
     9        even if an inner frame is focused. 
     10
     11        Layout tests aren't able to test this bug, since it requires closing
     12        the actual browser window, not calling window.close().  Instead,
     13        test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
     14
     15        * manual-tests/onbeforeunload-focused-iframe.html: Added.
     16        * manual-tests/resources/focused-iframe.html: Added.
     17
    1182010-02-08  Alexey Proskuryakov  <ap@apple.com>
    219

  • trunk/WebKit/chromium/ChangeLog

    r54515 r54519  
     12010-02-08  Charlie Reis  <creis@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        onbeforeunload not called at window close + frame or iframe focused
     6        https://bugs.webkit.org/show_bug.cgi?id=27481
     7        http://code.google.com/p/chromium/issues/detail?id=32615
     8        http://code.google.com/p/chromium/issues/detail?id=17157
     9
     10        Chromium and WebKit on Windows will now fire beforeunload handlers
     11        even if an inner frame is focused.
     12
     13        Layout tests aren't able to test this bug, since it requires closing
     14        the actual browser window, not calling window.close().  Instead,
     15        test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
     16
     17        * src/WebViewImpl.cpp:
     18        (WebKit::WebViewImpl::dispatchBeforeUnloadEvent):
     19
    1202010-02-08  Pavel Feldman  <pfeldman@chromium.org>
    221

  • trunk/WebKit/chromium/src/WebViewImpl.cpp

    r54458 r54519  
    11831183    // frames in the tree, calling each frame's onbeforeunload.  At the moment,
    11841184    // we're consistent with Safari 3.1, not IE/FF.
    1185     Frame* frame = m_page->focusController()->focusedOrMainFrame();
     1185    Frame* frame = m_page->mainFrame();
    11861186    if (!frame)
    11871187        return true;

  • trunk/WebKit/win/ChangeLog

    r54494 r54519  
     12010-02-08  Charlie Reis  <creis@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        onbeforeunload not called at window close + frame or iframe focused
     6        https://bugs.webkit.org/show_bug.cgi?id=27481
     7       
     8        Chromium and WebKit on Windows will now fire beforeunload handlers
     9        even if an inner frame is focused. 
     10
     11        Layout tests aren't able to test this bug, since it requires closing
     12        the actual browser window, not calling window.close().  Instead,
     13        test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
     14
     15        * WebView.cpp:
     16        (WebView::shouldClose):
     17
    1182010-02-08  Brent Fulgham  <bfulgham@webkit.org>
    219

  • trunk/WebKit/win/WebView.cpp

    r54293 r54519  
    50615061
    50625062    *result = TRUE;
    5063     if (Frame* frame = m_page->focusController()->focusedOrMainFrame())
     5063    if (Frame* frame = m_page->mainFrame())
    50645064        *result = frame->shouldClose() ? TRUE : FALSE;
    50655065    return S_OK;
Note: See TracChangeset for help on using the changeset viewer.