Changeset 54584 in webkit

Timestamp:

Feb 9, 2010 8:01:48 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-02-09 Chris Guillory <​ctguil@google.com>

Reviewed by Darin Fisher.

[Chromium] Notify ChromeClientChromium of state change notifications.

​https://bugs.webkit.org/show_bug.cgi?id=34464

• accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::toChromeClientChromium): (WebCore::AXObjectCache::postPlatformNotification):
• page/chromium/ChromeClientChromium.h:

2010-02-09 Chris Guillory <​ctguil@google.com>

Reviewed by Darin Fisher.

[Chromium] Add function for accessibility object state change notifications.

​https://bugs.webkit.org/show_bug.cgi?id=34464

• gyp_webkit:
• public/WebViewClient.h: (WebKit::WebViewClient::didChangeAccessibilityObjectState):
• src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::didChangeAccessibilityObjectState):
• src/ChromeClientImpl.h:

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/accessibility/chromium/AXObjectCacheChromium.cpp (modified) (2 diffs)
• WebCore/page/chromium/ChromeClientChromium.h (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/public/WebViewClient.h (modified) (1 diff)
• WebKit/chromium/src/ChromeClientImpl.cpp (modified) (1 diff)
• WebKit/chromium/src/ChromeClientImpl.h (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-02-09  Chris Guillory  <ctguil@google.com>
+
+        Reviewed by Darin Fisher.
+
+        [Chromium] Notify ChromeClientChromium of state change notifications.
+        
+        https://bugs.webkit.org/show_bug.cgi?id=34464
+
+        * accessibility/chromium/AXObjectCacheChromium.cpp:
+        (WebCore::toChromeClientChromium):
+        (WebCore::AXObjectCache::postPlatformNotification):
+        * page/chromium/ChromeClientChromium.h:
+
 2010-02-09  Kwang Yul Seo  <skyul@company100.net>
 

trunk/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp

@@ -27 +27 @@
 #include "config.h"
 #include "AXObjectCache.h"
-
 #include "AccessibilityObject.h"
+#include "Chrome.h"
+#include "ChromeClientChromium.h"
+#include "FrameView.h"
 
 namespace WebCore {
+
+static ChromeClientChromium* toChromeClientChromium(FrameView* view)
+{
+    Page* page = view->frame() ? view->frame()->page() : 0;
+    if (!page)
+        return 0;
+
+    return static_cast<ChromeClientChromium*>(page->chrome()->client());
+}
 
 void AXObjectCache::detachWrapper(AccessibilityObject* obj)
@@ -44 +55 @@
 }
 
-void AXObjectCache::postPlatformNotification(AccessibilityObject*, AXNotification)
+void AXObjectCache::postPlatformNotification(AccessibilityObject* obj, AXNotification notification)
 {
+    if (notification != AXCheckedStateChanged)
+        return;
+
+    if (!obj || !obj->document() || !obj->documentFrameView())
+        return;
+
+    ChromeClientChromium* client = toChromeClientChromium(obj->documentFrameView());
+    if (client)
+        client->didChangeAccessibilityObjectState(obj);
 }
 

trunk/WebCore/page/chromium/ChromeClientChromium.h

@@ -36 +36 @@
 
 namespace WebCore {
-    class IntRect;
-    class PopupContainer;
+class AccessibilityObject;
+class IntRect;
+class PopupContainer;
 
-    // Contains Chromium-specific extensions to the ChromeClient.  Only put
-    // things here that don't make sense for other ports.
-    class ChromeClientChromium : public ChromeClient {
-    public:
-        // Notifies the client of a new popup widget.  The client should place
-        // and size the widget with the given bounds, relative to the screen.
-        // If handleExternal is true, then drawing and input handling for the
-        // popup will be handled by the external embedder.
-        virtual void popupOpened(PopupContainer* popupContainer, const IntRect& bounds,
-                                 bool focusOnShow, bool handleExternal) = 0;
-    };
+// Contains Chromium-specific extensions to the ChromeClient.  Only put
+// things here that don't make sense for other ports.
+class ChromeClientChromium : public ChromeClient {
+public:
+    // Notifies the client of a new popup widget.  The client should place
+    // and size the widget with the given bounds, relative to the screen.
+    // If handleExternal is true, then drawing and input handling for the
+    // popup will be handled by the external embedder.
+    virtual void popupOpened(PopupContainer* popupContainer, const IntRect& bounds,
+                             bool focusOnShow, bool handleExternal) = 0;
+
+    // Notifies embedder that the state of an accessibility object has changed.
+    virtual void didChangeAccessibilityObjectState(AccessibilityObject*) = 0;
+};
 
 } // namespace WebCore

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-02-09  Chris Guillory  <ctguil@google.com>
+
+        Reviewed by Darin Fisher.
+
+        [Chromium] Add function for accessibility object state change notifications.
+        
+        https://bugs.webkit.org/show_bug.cgi?id=34464
+
+        * gyp_webkit:
+        * public/WebViewClient.h:
+        (WebKit::WebViewClient::didChangeAccessibilityObjectState):
+        * src/ChromeClientImpl.cpp:
+        (WebKit::ChromeClientImpl::didChangeAccessibilityObjectState):
+        * src/ChromeClientImpl.h:
+
 2010-02-09  Mikhail Naganov  <mnaganov@chromium.org>
 

trunk/WebKit/chromium/public/WebViewClient.h

@@ -253 +253 @@
     virtual void focusAccessibilityObject(const WebAccessibilityObject&) { }
 
+    // Notifies embedder that the state of an accessibility object has changed.
+    virtual void didChangeAccessibilityObjectState(const WebAccessibilityObject&) { }
+
 
     // Developer tools -----------------------------------------------------

trunk/WebKit/chromium/src/ChromeClientImpl.cpp

@@ -660 +660 @@
 }
 
+void ChromeClientImpl::didChangeAccessibilityObjectState(AccessibilityObject* obj)
+{
+    // Alert assistive technology about the accessibility object state change
+    if (obj)
+        m_webView->client()->didChangeAccessibilityObjectState(WebAccessibilityObject(obj));
+}
+
+
 #if ENABLE(NOTIFICATIONS)
 NotificationPresenter* ChromeClientImpl::notificationPresenter() const

trunk/WebKit/chromium/src/ChromeClientImpl.h

@@ -35 +35 @@
 
 namespace WebCore {
+class AccessibilityObject;
 class HTMLParserQuirks;
 class PopupContainer;
@@ -133 +134 @@
                              bool activatable,
                              bool handleExternally);
+    virtual void didChangeAccessibilityObjectState(WebCore::AccessibilityObject*);
 
     // ChromeClientImpl: