Changeset 54612 in webkit


Ignore:
Timestamp:
Feb 10, 2010 11:26:49 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-02-10 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
to make Qt DRT able to get page number.

LayoutTests:

printing/page-break-always.html
printing/pageNumerForElementById.html
printing/css2.1/page-break-before-000.html
printing/css2.1/page-break-after-000.html
printing/css2.1/page-break-after-004.html
printing/css2.1/page-break-before-001.html
printing/css2.1/page-break-after-001.html
printing/css2.1/page-break-after-002.html
printing/css2.1/page-break-before-002.html
printing/css2.1/page-break-inside-000.html

[Qt] Make possible Qt DRT get a page number for element by ID
​https://bugs.webkit.org/show_bug.cgi?id=34777

  • platform/qt/Skipped:

2010-02-10 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
to make Qt DRT able to get page number.

LayoutTests:

printing/page-break-always.html
printing/pageNumerForElementById.html
printing/css2.1/page-break-before-000.html
printing/css2.1/page-break-after-000.html
printing/css2.1/page-break-after-004.html
printing/css2.1/page-break-before-001.html
printing/css2.1/page-break-after-001.html
printing/css2.1/page-break-after-002.html
printing/css2.1/page-break-before-002.html
printing/css2.1/page-break-inside-000.html

[Qt] Make possible Qt DRT get a page number for element by ID
​https://bugs.webkit.org/show_bug.cgi?id=34777

  • Api/qwebframe.cpp: (qt_drt_pageNumberForElementById):

2010-02-10 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
to make Qt DRT able to get page number.

LayoutTests:

printing/page-break-always.html
printing/pageNumerForElementById.html
printing/css2.1/page-break-before-000.html
printing/css2.1/page-break-after-000.html
printing/css2.1/page-break-after-004.html
printing/css2.1/page-break-before-001.html
printing/css2.1/page-break-after-001.html
printing/css2.1/page-break-after-002.html
printing/css2.1/page-break-before-002.html
printing/css2.1/page-break-inside-000.html

[Qt] Make possible Qt DRT get a page number for element by ID
​https://bugs.webkit.org/show_bug.cgi?id=34777

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::pageNumberForElementById):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r54608 r54612  
     12010-02-10  Diego Gonzalez  <diego.gonzalez@openbossa.org>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
     6        to make Qt DRT able to get page number.
     7
     8        LayoutTests:
     9            printing/page-break-always.html
     10            printing/pageNumerForElementById.html
     11            printing/css2.1/page-break-before-000.html
     12            printing/css2.1/page-break-after-000.html
     13            printing/css2.1/page-break-after-004.html
     14            printing/css2.1/page-break-before-001.html
     15            printing/css2.1/page-break-after-001.html
     16            printing/css2.1/page-break-after-002.html
     17            printing/css2.1/page-break-before-002.html
     18            printing/css2.1/page-break-inside-000.html
     19
     20        [Qt] Make possible Qt DRT get a page number for element by ID
     21        https://bugs.webkit.org/show_bug.cgi?id=34777
     22
     23        * platform/qt/Skipped:
     24
    1252010-02-10  Jeremy Orlow  <jorlow@chromium.org>
    226

  • trunk/LayoutTests/platform/qt/Skipped

    r54607 r54612  
    50735073fast/loader/crash-copying-backforwardlist.html
    50745074
    5075 # Implement LayoutTestController::pageNumberForElementById().
    5076 printing/page-break-always.html
    5077 printing/pageNumerForElementById.html
    5078 printing/css2.1
    5079 
    50805075# Because ENABLE_DASHBOARD_SUPPORT=0 is the default option. (Apple's dashboard support in OS X)
    50815076fast/css/dashboard-regions-attr-crash.html

  • trunk/WebKit/qt/Api/qwebframe.cpp

    r53997 r54612  
    221221}
    222222
     223int QWEBKIT_EXPORT qt_drt_pageNumberForElementById(QWebFrame* qFrame, const QString& id, float width, float height)
     224{
     225    Frame* frame = QWebFramePrivate::core(qFrame);
     226    if (!frame)
     227        return -1;
     228
     229    Element* element = frame->document()->getElementById(AtomicString(id));
     230    if (!element)
     231        return -1;
     232
     233    return PrintContext::pageNumberForElement(element, FloatSize(width, height));
     234}
     235
    223236// Suspend active DOM objects in this frame.
    224237void QWEBKIT_EXPORT qt_suspendActiveDOMObjects(QWebFrame* qFrame)

  • trunk/WebKit/qt/ChangeLog

    r54578 r54612  
     12010-02-10  Diego Gonzalez  <diego.gonzalez@openbossa.org>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
     6        to make Qt DRT able to get page number.
     7
     8        LayoutTests:
     9            printing/page-break-always.html
     10            printing/pageNumerForElementById.html
     11            printing/css2.1/page-break-before-000.html
     12            printing/css2.1/page-break-after-000.html
     13            printing/css2.1/page-break-after-004.html
     14            printing/css2.1/page-break-before-001.html
     15            printing/css2.1/page-break-after-001.html
     16            printing/css2.1/page-break-after-002.html
     17            printing/css2.1/page-break-before-002.html
     18            printing/css2.1/page-break-inside-000.html
     19
     20        [Qt] Make possible Qt DRT get a page number for element by ID
     21        https://bugs.webkit.org/show_bug.cgi?id=34777
     22
     23        * Api/qwebframe.cpp:
     24        (qt_drt_pageNumberForElementById):
     25
    1262010-02-09  Yael Aharon  <yael.aharon@nokia.com>
    227

  • trunk/WebKitTools/ChangeLog

    r54590 r54612  
     12010-02-10  Diego Gonzalez  <diego.gonzalez@openbossa.org>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
     6        to make Qt DRT able to get page number.
     7
     8        LayoutTests:
     9            printing/page-break-always.html
     10            printing/pageNumerForElementById.html
     11            printing/css2.1/page-break-before-000.html
     12            printing/css2.1/page-break-after-000.html
     13            printing/css2.1/page-break-after-004.html
     14            printing/css2.1/page-break-before-001.html
     15            printing/css2.1/page-break-after-001.html
     16            printing/css2.1/page-break-after-002.html
     17            printing/css2.1/page-break-before-002.html
     18            printing/css2.1/page-break-inside-000.html
     19
     20        [Qt] Make possible Qt DRT get a page number for element by ID
     21        https://bugs.webkit.org/show_bug.cgi?id=34777
     22
     23        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
     24        (LayoutTestController::pageNumberForElementById):
     25        * DumpRenderTree/qt/LayoutTestControllerQt.h:
     26
    1272010-02-10  Andras Becsi  <abecsi@webkit.org>
    228

  • trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp

    r54501 r54612  
    5050extern QString qt_drt_counterValueForElementById(QWebFrame* qFrame, const QString& id);
    5151extern int qt_drt_workerThreadCount();
     52extern int qt_drt_pageNumberForElementById(QWebFrame* qFrame, const QString& id, float width, float height);
    5253
    5354LayoutTestController::LayoutTestController(WebCore::DumpRenderTree* drt)
    … …  
    455456    return qt_drt_workerThreadCount();
    456457}
     458
     459int LayoutTestController::pageNumberForElementById(const QString& id, float width, float height)
     460{
     461    // If no size specified, webpage viewport size is used
     462    if (!width && !height) {
     463        width = m_drt->webPage()->viewportSize().width();
     464        height = m_drt->webPage()->viewportSize().height();
     465    }
     466
     467    return qt_drt_pageNumberForElementById(m_drt->webPage()->mainFrame(), id, width, height);
     468}

  • trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h

    r54440 r54612  
    149149    void setDomainRelaxationForbiddenForURLScheme(bool forbidden, const QString& scheme);
    150150    int workerThreadCount();
     151    int pageNumberForElementById(const QString& id, float width = 0, float height = 0);
    151152
    152153private slots:
Note: See TracChangeset for help on using the changeset viewer.