Changeset 54950 in webkit


Ignore:
Timestamp:
Feb 18, 2010 2:21:25 AM (14 years ago)
Author:
benm@google.com
Message:

[v8] [Android] V8 bindings for touch events are missing.
https://bugs.webkit.org/show_bug.cgi?id=33795

Reviewed by Nate Chapin.

No new tests as this just enables touch events in V8. Existing touch tests suffice.

  • WebCore.gypi: Add Touch idl files.
  • bindings/scripts/CodeGeneratorV8.pm: Add TouchList to typeCanFailConversion map.
  • bindings/v8/DOMObjectsInclude.h: Add touch headers.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Add touch generated bindings.
  • bindings/v8/V8Index.h: Add touch DOM object types.
  • bindings/v8/custom/V8EventCustom.cpp: Add conversion of event to touch event.
  • Android.derived.jscbindings.mk: Add the touch derived sources to the makefile.
  • Android.derived.v8bindings.mk: Add the touch derived sources to the makefile.
Location:
trunk/WebCore
Files:
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/Android.derived.jscbindings.mk

    r53574 r54950  
    133133    $(intermediates)/dom/JSText.h \
    134134    $(intermediates)/dom/JSTextEvent.h \
     135    $(intermediates)/dom/JSTouch.h \
     136    $(intermediates)/dom/JSTouchEvent.h \
     137    $(intermediates)/dom/JSTouchList.h \
    135138    $(intermediates)/dom/JSTreeWalker.h \
    136139    $(intermediates)/dom/JSUIEvent.h \
  • trunk/WebCore/Android.derived.v8bindings.mk

    r54653 r54950  
    114114    $(intermediates)/bindings/V8Text.h \
    115115    $(intermediates)/bindings/V8TextEvent.h \
     116    $(intermediates)/bindings/V8Touch.h \
     117    $(intermediates)/bindings/V8TouchEvent.h \
     118    $(intermediates)/bindings/V8TouchList.h \
    116119    $(intermediates)/bindings/V8TreeWalker.h \
    117120    $(intermediates)/bindings/V8UIEvent.h \
  • trunk/WebCore/ChangeLog

    r54946 r54950  
     12010-02-18  Ben Murdoch  <benm@google.com>
     2
     3        Reviewed by Nate Chapin.
     4
     5        [v8] [Android] V8 bindings for touch events are missing.
     6        https://bugs.webkit.org/show_bug.cgi?id=33795
     7
     8        No new tests as this just enables touch events in V8. Existing touch tests suffice.
     9
     10        * WebCore.gypi: Add Touch idl files.
     11        * bindings/scripts/CodeGeneratorV8.pm: Add TouchList to typeCanFailConversion map.
     12        * bindings/v8/DOMObjectsInclude.h: Add touch headers.
     13        * bindings/v8/DerivedSourcesAllInOne.cpp: Add touch generated bindings.
     14        * bindings/v8/V8Index.h: Add touch DOM object types.
     15        * bindings/v8/custom/V8EventCustom.cpp: Add conversion of event to touch event.
     16        * Android.derived.jscbindings.mk: Add the touch derived sources to the makefile.
     17        * Android.derived.v8bindings.mk: Add the touch derived sources to the makefile.
     18
    1192010-02-18  William Chan  <willchan@chromium.org>
    220
  • trunk/WebCore/WebCore.gypi

    r54911 r54950  
    7474            'dom/Text.idl',
    7575            'dom/TextEvent.idl',
     76            'dom/Touch.idl',
     77            'dom/TouchEvent.idl',
     78            'dom/TouchList.idl',
    7679            'dom/TreeWalker.idl',
    7780            'dom/UIEvent.idl',
  • trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r54680 r54950  
    24612461    "SVGRect" => 1,
    24622462    "SVGTransform" => 1,
     2463    "TouchList" => 0,
    24632464    "VoidCallback" => 1,
    24642465    "WebKitCSSMatrix" => 0,
  • trunk/WebCore/bindings/v8/DOMObjectsInclude.h

    r54085 r54950  
    283283#endif // INSPECTOR
    284284
     285#if ENABLE(TOUCH_EVENTS)
     286#include "Touch.h"
     287#include "TouchEvent.h"
     288#include "TouchList.h"
     289#endif
     290
    285291namespace WebCore {
    286292
  • trunk/WebCore/bindings/v8/DerivedSourcesAllInOne.cpp

    r54085 r54950  
    220220#include "bindings/V8TextMetrics.cpp"
    221221#include "bindings/V8TimeRanges.cpp"
     222#include "bindings/V8Touch.cpp"
     223#include "bindings/V8TouchEvent.cpp"
     224#include "bindings/V8TouchList.cpp"
    222225#include "bindings/V8TreeWalker.cpp"
    223226#include "bindings/V8UIEvent.cpp"
  • trunk/WebCore/bindings/v8/V8Index.h

    r54503 r54950  
    527527    V(POSITIONERROR, PositionError)
    528528
     529#if ENABLE(TOUCH_EVENTS)
     530#define DOM_OBJECT_TOUCH_EVENT_TYPES(V)                                 \
     531    V(TOUCH, Touch)                                                     \
     532    V(TOUCHEVENT, TouchEvent)                                           \
     533    V(TOUCHLIST, TouchList)
     534#else
     535#define DOM_OBJECT_TOUCH_EVENT_TYPES(V)
     536#endif
     537
    529538#define DOM_OBJECT_TYPES(V)                                             \
    530539    DOM_OBJECT_TYPES_1(V)                                               \
     
    538547    DOM_OBJECT_XSLT_TYPES(V)                                            \
    539548    DOM_OBJECT_INSPECTOR_TYPES(V)                                       \
    540     DOM_OBJECT_GEOLOCATION_TYPES(V)
     549    DOM_OBJECT_GEOLOCATION_TYPES(V)                                     \
     550    DOM_OBJECT_TOUCH_EVENT_TYPES(V)
    541551
    542552#if ENABLE(SVG)
  • trunk/WebCore/bindings/v8/custom/V8EventCustom.cpp

    r54305 r54950  
    5252#include "V8StorageEvent.h"
    5353#include "V8TextEvent.h"
     54#include "V8TouchEvent.h"
    5455#include "V8UIEvent.h"
    5556#include "V8WebKitAnimationEvent.h"
     
    105106        if (impl->isCompositionEvent())
    106107            return toV8(static_cast<CompositionEvent*>(impl));
     108#if ENABLE(TOUCH_EVENTS)
     109        if (impl->isTouchEvent())
     110            return toV8(static_cast<TouchEvent*>(impl));
     111#endif
    107112        return toV8(static_cast<UIEvent*>(impl));
    108113    }
Note: See TracChangeset for help on using the changeset viewer.