Changeset 55124 in webkit

Timestamp:

Feb 23, 2010 12:09:54 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-02-23 José Millán Soto <​jmillan@igalia.com>

Reviewed by Eric Seidel.

[Gtk] Webkit crashes when using orca
​https://bugs.webkit.org/show_bug.cgi?id=35169

Made webkit_accessible_text_get_caret_offset check if end selection
node is null.

• accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/gtk/AccessibilityObjectWrapperAtk.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-02-23  José Millán Soto  <jmillan@igalia.com>
+
+        Reviewed by Eric Seidel.
+
+        [Gtk] Webkit crashes when using orca
+        https://bugs.webkit.org/show_bug.cgi?id=35169
+
+        Made webkit_accessible_text_get_caret_offset check if end selection
+        node is null.
+
+        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+        (webkit_accessible_text_get_caret_offset):
+
 2010-02-22  Stephan Aßmus  <superstippi@gmx.de>
 

trunk/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp

@@ -997 +997 @@
     // focusedObject is the object with the caret. It is likely ignored -- unless it's a link.
     AccessibilityObject* coreObject = core(text);
-    RenderObject* focusedNode = coreObject->selection().end().node()->renderer();
-    AccessibilityObject* focusedObject = coreObject->document()->axObjectCache()->getOrCreate(focusedNode);
+    Node* focusedNode = coreObject->selection().end().node();
+
+    if (!focusedNode)
+        return 0;
+
+    RenderObject* focusedRenderer = focusedNode->renderer();
+    AccessibilityObject* focusedObject = coreObject->document()->axObjectCache()->getOrCreate(focusedRenderer);
 
     int offset;