Changeset 55255 in webkit

Timestamp:

Feb 25, 2010 2:14:51 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-02-25 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Javascript console should not attempt to scroll to end of console if console is not visible

​https://bugs.webkit.org/show_bug.cgi?id=22992

• inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView): (WebInspector.ConsoleView.prototype._scheduleScrollIntoView): (WebInspector.ConsoleView.prototype.addMessage):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ConsoleView.js (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-02-25  Alexander Pavlov  <apavlov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Javascript console should not attempt to scroll to end of console if console is not visible
+
+        https://bugs.webkit.org/show_bug.cgi?id=22992
+
+        * inspector/front-end/ConsoleView.js:
+        (WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView):
+        (WebInspector.ConsoleView.prototype._scheduleScrollIntoView):
+        (WebInspector.ConsoleView.prototype.addMessage):
+
 2010-02-25  Alexey Proskuryakov  <ap@apple.com>
 

trunk/WebCore/inspector/front-end/ConsoleView.js

@@ -216 +216 @@
     },
 
+    _scheduleScrollIntoView: function()
+    {
+        if (this._scrollIntoViewTimer)
+            return;
+
+        function scrollIntoView()
+        {
+            this.promptElement.scrollIntoView(false);
+            delete this._scrollIntoViewTimer;
+        }
+        this._scrollIntoViewTimer = setTimeout(scrollIntoView.bind(this), 20);
+    },
+
     addMessage: function(msg)
     {
@@ -257 +270 @@
         }
 
-        this.promptElement.scrollIntoView(false);
+        this._scheduleScrollIntoView();
     },