Changeset 55268 in webkit

Timestamp:

Feb 25, 2010 5:32:15 PM (14 years ago)

Author:

dpranke@chromium.org

Message:

2010-02-25 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Add a 'passing' port implementation to new-run-webkit-tests that
acts as a wrapper around an existing implementation but stubs out
the actual test invocations (instead, the expected results are echoed
back to the harness). This is useful for coverage and perf testing
of the harness (especially perf testing as it essentially provides
a lower bound on how fast the harness can run).

Also added a --nostart-helper flag to new-run-webkit-tests so that
you can skip starting the layout_test_helper and actually run the
harness even if you don't have a build of that port.

Also fix a bug in the 'test' port implementation to actually
create the results directory under /tmp instead of /.

​https://bugs.webkit.org/show_bug.cgi?id=35370

• Scripts/webkitpy/layout_tests/port/factory.py: Modified.
• Scripts/webkitpy/layout_tests/port/passing.py: Added.
• Scripts/webkitpy/layout_tests/port/test.py: Added.
• Scripts/webkitpy/layout_tests/run_webkit_tests.py: Modified.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/factory.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/passing.py (added)
• Scripts/webkitpy/layout_tests/port/test.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/run_webkit_tests.py (modified) (3 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-02-25  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Add a 'passing' port implementation to new-run-webkit-tests that
+        acts as a wrapper around an existing implementation but stubs out
+        the actual test invocations (instead, the expected results are echoed
+        back to the harness). This is useful for coverage and perf testing
+        of the harness (especially perf testing as it essentially provides
+        a lower bound on how fast the harness can run).
+
+        Also added a --nostart-helper flag to new-run-webkit-tests so that
+        you can skip starting the layout_test_helper and actually run the
+        harness even if you don't have a build of that port.
+
+        Also fix a bug in the 'test' port implementation to actually
+        create the results directory under /tmp instead of /.
+
+        https://bugs.webkit.org/show_bug.cgi?id=35370
+
+        * Scripts/webkitpy/layout_tests/port/factory.py: Modified.
+        * Scripts/webkitpy/layout_tests/port/passing.py: Added.
+        * Scripts/webkitpy/layout_tests/port/test.py: Added.
+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Modified.
+
 2010-02-25  Eric Seidel  <eric@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/factory.py

@@ -50 +50 @@
         import test
         return test.TestPort(port_name, options)
+    elif port_to_use.startswith('passing'):
+        import passing
+        return passing.PassingPort(port_name, options)
     elif port_to_use.startswith('mac'):
         import mac

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/test.py

@@ -77 +77 @@
 
     def results_directory(self):
-        return '/tmp' + self._options.results_directory
+        return '/tmp/' + self._options.results_directory
 
     def setup_test_run(self):

trunk/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -1469 +1469 @@
                                    options.target == 'Debug')
 
-    port_obj.start_helper()
+    if not options.nostart_helper:
+        port_obj.start_helper()
 
     # Check that the system dependencies (themes, fonts, ...) are correct.
@@ -1491 +1492 @@
     has_new_failures = test_runner.run(result_summary)
 
-    port_obj.stop_helper()
+    if not options.nostart_helper:
+        port_obj.stop_helper()
 
     logging.debug("Exit status: %d" % has_new_failures)
@@ -1620 +1622 @@
                              action="store_true", default=False,
                              help="run all tests in parallel")
+    option_parser.add_option("", "--nostart-helper",
+                             action="store_true", default=False,
+                             help="don't run layout_test_helper")
     return option_parser.parse_args(args)