Changeset 55282 in webkit


Ignore:
Timestamp:
Feb 26, 2010 7:30:30 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-02-26 Zhenyao Mo <zmo@google.com>

Reviewed by David Levin.

Set viewport to canvas size upon context creation
https://bugs.webkit.org/show_bug.cgi?id=35057

  • fast/canvas/webgl/bug-32888.html: Remove the gl.viewport call since it's done when WebGLRenderingContext is created.
  • fast/canvas/webgl/gl-get-calls-expected.txt: The read-back viewport size should match the canvas size instead of (0, 0, 0, 0).
  • fast/canvas/webgl/gl-get-calls.html: Remove the gl.viewport call since it's done when WebGLRenderingContext is created.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html: Ditto.
  • fast/canvas/webgl/tex-sub-image-2d.html: Ditto.
  • fast/canvas/webgl/texImage2DImageDataTest.html: Ditto.
  • fast/canvas/webgl/triangle.html: Ditto.
  • fast/canvas/webgl/viewport-unchanged-upon-resize.html: Ditto.

2010-02-26 Zhenyao Mo <zmo@google.com>

Reviewed by David Levin.

Set viewport to canvas size upon context creation
https://bugs.webkit.org/show_bug.cgi?id=35057

Covered by existing tests, in particular fast/canvas/webgl/gl-get-calls.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Set the viewport size to match the canvas size.
Location:
trunk
Files:
11 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r55281 r55282  
     12010-02-26  Zhenyao Mo  <zmo@google.com>
     2
     3        Reviewed by David Levin.
     4
     5        Set viewport to canvas size upon context creation
     6        https://bugs.webkit.org/show_bug.cgi?id=35057
     7
     8        * fast/canvas/webgl/bug-32888.html: Remove the gl.viewport call since it's done when WebGLRenderingContext is created.
     9        * fast/canvas/webgl/gl-get-calls-expected.txt: The read-back viewport size should match the canvas size instead of (0, 0, 0, 0).
     10        * fast/canvas/webgl/gl-get-calls.html: Remove the gl.viewport call since it's done when WebGLRenderingContext is created.
     11        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html: Ditto.
     12        * fast/canvas/webgl/tex-sub-image-2d.html: Ditto.
     13        * fast/canvas/webgl/texImage2DImageDataTest.html: Ditto.
     14        * fast/canvas/webgl/triangle.html: Ditto.
     15        * fast/canvas/webgl/viewport-unchanged-upon-resize.html: Ditto.
     16
    1172010-02-26  Csaba Osztrogonác  <ossy@webkit.org>
    218
  • trunk/LayoutTests/fast/canvas/webgl/bug-32888.html

    r52517 r55282  
    4444
    4545    gl = initWebGL("example", "vshader", "fshader", [ "g_Position", "g_TexCoord0" ], [ 0, 0, 0, 1 ], 1);
    46     gl.viewport(0, 0, 32, 32);
    4746
    4847    textureLoc = gl.getUniformLocation(gl.program, "tex");
  • trunk/LayoutTests/fast/canvas/webgl/gl-get-calls-expected.txt

    r54625 r55282  
    6464PASS context.getParameter(context.TEXTURE_BINDING_2D) is null
    6565PASS context.getParameter(context.TEXTURE_BINDING_CUBE_MAP) is null
    66 PASS context.getParameter(context.VIEWPORT) is [0, 0, 0, 0]
     66PASS context.getParameter(context.VIEWPORT) is [0, 0, 2, 2]
    6767
    6868PASS successfullyParsed is true
  • trunk/LayoutTests/fast/canvas/webgl/gl-get-calls.html

    r54625 r55282  
    9595    shouldBe('context.getParameter(context.TEXTURE_BINDING_2D)', 'null');
    9696    shouldBe('context.getParameter(context.TEXTURE_BINDING_CUBE_MAP)', 'null');
    97     shouldBe('context.getParameter(context.VIEWPORT)', '[0, 0, 0, 0]');
     97    shouldBe('context.getParameter(context.VIEWPORT)', '[0, 0, 2, 2]');
    9898}
    9999
  • trunk/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html

    r54907 r55282  
    4646
    4747    gl = initWebGL("example", "vshader", "fshader", [ "g_Position", "g_TexCoord0" ], [ 0, 0, 0, 1 ], 1);
    48     gl.viewport(0, 0, 32, 32);
    4948
    5049    textureLoc = gl.getUniformLocation(gl.program, "tex");
  • trunk/LayoutTests/fast/canvas/webgl/tex-sub-image-2d.html

    r53640 r55282  
    4242var textureWidth = 256;
    4343var textureHeight = 1;
    44 
    45 gl.viewport(0, 0, textureWidth, textureHeight);
    4644
    4745textureLoc = gl.getUniformLocation(gl.program, "tex");
  • trunk/LayoutTests/fast/canvas/webgl/texImage2DImageDataTest.html

    r54625 r55282  
    6060                       
    6161            gl = initWebGL("example", "vshader", "fshader", [ "vPosition", "vTexCoord0"], [ 1, 0, 1, 1 ], 100);
    62             gl.viewport(0, 0, 64, 64);
    6362            gl.clear(gl.COLOR_BUFFER_BIT | gl.DEPTH_BUFFER_BIT);
    6463           
  • trunk/LayoutTests/fast/canvas/webgl/triangle.html

    r51348 r55282  
    4040           
    4141            gl = initWebGL("example", "vshader", "fshader", [ "vPosition"], [ 0, 0, 0, 1 ], 1);
    42             gl.viewport(0, 0, 50, 50);
    4342           
    4443            var vertexObject = gl.createBuffer();
  • trunk/LayoutTests/fast/canvas/webgl/viewport-unchanged-upon-resize.html

    r54625 r55282  
    3232
    3333var gl = initWebGL("example", "vshader", "fshader", [ "g_Position" ], [ 0, 0, 1, 1 ], 1);
    34 
    35 gl.viewport(0, 0, 4, 4);
    3634
    3735var vertices = new WebGLFloatArray([
  • trunk/WebCore/ChangeLog

    r55278 r55282  
     12010-02-26  Zhenyao Mo  <zmo@google.com>
     2
     3        Reviewed by David Levin.
     4
     5        Set viewport to canvas size upon context creation
     6        https://bugs.webkit.org/show_bug.cgi?id=35057
     7
     8        Covered by existing tests, in particular fast/canvas/webgl/gl-get-calls.html
     9
     10        * html/canvas/WebGLRenderingContext.cpp:
     11        (WebCore::WebGLRenderingContext::WebGLRenderingContext): Set the viewport size to match the canvas size.
     12
    1132010-02-26  Pavel Feldman  <pfeldman@chromium.org>
    214
  • trunk/WebCore/html/canvas/WebGLRenderingContext.cpp

    r53238 r55282  
    9898    m_maxVertexAttribs = numVertexAttribs;
    9999    m_context->reshape(canvas()->width(), canvas()->height());
     100    m_context->viewport(0, 0, canvas()->width(), canvas()->height());
    100101}
    101102
Note: See TracChangeset for help on using the changeset viewer.