Changeset 55284 in webkit

Timestamp:

Feb 26, 2010 8:19:43 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-02-26 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

Changed the diff_parser module to log to a module-specific
logging.logger rather than the root logger.

​https://bugs.webkit.org/show_bug.cgi?id=35391

• Scripts/webkitpy/diff_parser.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/diff_parser.py (modified) (3 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-02-26  Chris Jerdonek  <cjerdonek@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Changed the diff_parser module to log to a module-specific
+        logging.logger rather than the root logger.
+
+        https://bugs.webkit.org/show_bug.cgi?id=35391
+
+        * Scripts/webkitpy/diff_parser.py:
+
 2010-02-26  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/diff_parser.py

@@ -32 +32 @@
 import re
 
+_log = logging.getLogger("webkitpy.diff_parser")
 
 _regexp_compile_cache = {}
@@ -139 +140 @@
             if lines_changed:
                 if state != _DECLARED_FILE_PATH and state != _PROCESSING_CHUNK:
-                    logging.error('Unexpected line change without file path declaration: %r' % line)
+                    _log.error('Unexpected line change without file path '
+                               'declaration: %r' % line)
                 old_diff_line = int(lines_changed.group('OldStartLine'))
                 new_diff_line = int(lines_changed.group('NewStartLine'))
@@ -160 +162 @@
                     pass
                 else:
-                    logging.error('Unexpected diff format when parsing a chunk: %r' % line)
+                    _log.error('Unexpected diff format when parsing a '
+                               'chunk: %r' % line)