Changeset 55295 in webkit

Timestamp:

Feb 26, 2010 10:54:02 AM (14 years ago)

Author:

alex

Message:

[GTK] Some region checks in scroll are not required
​https://bugs.webkit.org/show_bug.cgi?id=35142

Reviewed by Xan Lopez.

Removes some of the operations checking the moved and invalidated
regions when scrolling, it is done already in
gdk_window_move_region.

• WebCoreSupport/ChromeClientGtk.cpp:

Location:

trunk/WebKit/gtk

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/ChromeClientGtk.cpp (modified) (1 diff)

trunk/WebKit/gtk/ChangeLog

@@ +1 @@
+2010-02-19  Alejandro G. Castro  <alex@igalia.com>
+
+        Reviewed by Xan Lopez.
+
+        [GTK] Some region checks in scroll are not required
+        https://bugs.webkit.org/show_bug.cgi?id=35142
+
+        Removes some of the operations checking the moved and invalidated
+        regions when scrolling, it is done already in
+        gdk_window_move_region.
+
+        * WebCoreSupport/ChromeClientGtk.cpp:
+
 2010-02-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 

trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

@@ -365 +365 @@
     // scroll the whole window at once, and we often need to scroll
     // portions of the window only (think frames).
-    GdkRectangle area = clipRect;
-    GdkRectangle moveRect;
-
-    GdkRectangle sourceRect = area;
-    sourceRect.x -= delta.width();
-    sourceRect.y -= delta.height();
-
-    GdkRegion* invalidRegion = gdk_region_rectangle(&area);
-
-    if (gdk_rectangle_intersect(&area, &sourceRect, &moveRect)) {
-        GdkRegion* moveRegion = gdk_region_rectangle(&moveRect);
-        gdk_window_move_region(window, moveRegion, delta.width(), delta.height());
-        gdk_region_offset(moveRegion, delta.width(), delta.height());
-        gdk_region_subtract(invalidRegion, moveRegion);
-        gdk_region_destroy(moveRegion);
-    }
-
-    gdk_window_invalidate_region(window, invalidRegion, FALSE);
-    gdk_region_destroy(invalidRegion);
+    GdkRectangle moveRect = clipRect;
+    GdkRegion* moveRegion = gdk_region_rectangle(&moveRect);
+    gdk_window_move_region(window, moveRegion, delta.width(), delta.height());
+    gdk_region_destroy(moveRegion);
 }