Changeset 55326 in webkit

Timestamp:

Feb 26, 2010 5:17:55 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-02-26 Robert Kroeger <​rjkroege@chromium.org>

Reviewed by Nate Chapin

To fire each event handler registered on an SVG node once per
event, Chromium needs an implementation of wasCreatedFromMarkup
added to V8LazyEventListener.h that matches the one in
WebKit/WebCore/bindings/js/JSLazyEventListener.h.

This patch adds such a matching implementation of wasCreatedFromMarkup
to V8LazyEventListener.h.

​https://bugs.webkit.org/show_bug.cgi?id=35325

• bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::wasCreatedFromMarkup):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8LazyEventListener.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-02-26  Robert Kroeger  <rjkroege@chromium.org>
+
+        Reviewed by Nate Chapin
+
+        To fire each event handler registered on an SVG node once per
+        event, Chromium needs an implementation of wasCreatedFromMarkup
+        added to V8LazyEventListener.h that matches the one in
+        WebKit/WebCore/bindings/js/JSLazyEventListener.h.
+        
+        This patch adds such a matching implementation of wasCreatedFromMarkup
+        to V8LazyEventListener.h.
+        
+        https://bugs.webkit.org/show_bug.cgi?id=35325
+
+        * bindings/v8/V8LazyEventListener.h:
+        (WebCore::V8LazyEventListener::wasCreatedFromMarkup):
+
 2010-02-26  Arno Renevier  <arno@renevier.net>
 

trunk/WebCore/bindings/v8/V8LazyEventListener.h

@@ -61 +61 @@
         virtual v8::Local<v8::Value> callListenerFunction(ScriptExecutionContext*, v8::Handle<v8::Value> jsEvent, Event*);
 
+        // Needs to return true for all event handlers implemented in JavaScript so that
+        // the SVG code does not add the event handler in both
+        // SVGUseElement::buildShadowTree and again in
+        // SVGUseElement::transferEventListenersToShadowTree
+        virtual bool wasCreatedFromMarkup() const { return true; }
+
         String m_functionName;
         bool m_isSVGEvent;