Changeset 55380 in webkit

Timestamp:

Mar 1, 2010 2:27:22 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-03-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

EWS can hang for five hours when compile output is too big
​https://bugs.webkit.org/show_bug.cgi?id=35545

• Scripts/webkitpy/commands/queues.py: Limit uploads to 1MB instead of 5MB. AppEngine seems to not like 5MB uploads. I'm not sure what the limit is. Let's try 1MB for a while and see how it goes.
• Scripts/webkitpy/networktransaction.py: Tune the default parameters to our exponential backoff. I'm not sure why I picked five hours as the retry limit. That seems way too large.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/commands/queues.py (modified) (1 diff)
• Scripts/webkitpy/networktransaction.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-03-01  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        EWS can hang for five hours when compile output is too big
+        https://bugs.webkit.org/show_bug.cgi?id=35545
+
+        * Scripts/webkitpy/commands/queues.py: Limit uploads to 1MB instead of
+        5MB.  AppEngine seems to not like 5MB uploads.  I'm not sure what the
+        limit is.  Let's try 1MB for a while and see how it goes.
+        * Scripts/webkitpy/networktransaction.py: Tune the default parameters
+        to our exponential backoff.  I'm not sure why I picked five hours as
+        the retry limit.  That seems way too large.
+
 2010-03-01  Brady Eidson  <beidson@apple.com>
 

trunk/WebKitTools/Scripts/webkitpy/commands/queues.py

@@ -133 +133 @@
         if is_error:
             message = "Error: %s" % message
-        output = script_error.message_with_output(output_limit=5*1024*1024) # 5MB
+        output = script_error.message_with_output(output_limit=1024*1024) # 1MB
         return tool.status_server.update_status(cls.name, message, state["patch"], StringIO(output))
 

trunk/WebKitTools/Scripts/webkitpy/networktransaction.py

@@ -38 +38 @@
 
 class NetworkTransaction(object):
-    def __init__(self, initial_backoff_seconds=10, grown_factor=1.1, timeout_seconds=5*60*60):
+    def __init__(self, initial_backoff_seconds=10, grown_factor=1.5, timeout_seconds=10*60):
         self._initial_backoff_seconds = initial_backoff_seconds
         self._grown_factor = grown_factor