Changeset 55405 in webkit

Timestamp:

Mar 2, 2010 1:59:28 AM (14 years ago)

Author:

zecke@webkit.org

Message:

[Gtk] Support private browsing mode in plugins.

​https://bugs.webkit.org/show_bug.cgi?id=35500

Integrate the PluginViewQt.cpp changes from
r55358 into Gtk+ and unskip the test.

• plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::getValue):

• platform/gtk/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/plugins/gtk/PluginViewGtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-02-28  Holger Hans Peter Freyther  <zecke@selfish.org>
+
+        Reviewed by Gustavo Noronha.
+
+        [Gtk] Support private browsing mode in plugins.
+        https://bugs.webkit.org/show_bug.cgi?id=35500
+
+        Unskip test after taking code from PluginViewQt.cpp
+
+        * platform/gtk/Skipped:
+
 2010-02-27  Alexey Proskuryakov  <ap@apple.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -3591 +3591 @@
 # https://bugs.webkit.org/show_bug.cgi?id=30561
 plugins/private-browsing-mode.html
-# https://bugs.webkit.org/show_bug.cgi?id=33180
-plugins/private-browsing-mode-2.html
 
 #   Tests generating new results

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-02-28  Holger Hans Peter Freyther  <zecke@selfish.org>
+
+        Reviewed by Gustavo Noronha.
+
+        [Gtk] Support private browsing mode in plugins.
+        https://bugs.webkit.org/show_bug.cgi?id=35500
+
+        Integrate the PluginViewQt.cpp changes from r55358 into Gtk+.
+
+        * plugins/gtk/PluginViewGtk.cpp:
+        (WebCore::PluginView::getValue):
+
 2010-03-02  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/plugins/gtk/PluginViewGtk.cpp

@@ -701 +701 @@
         }
 
+        case NPNVprivateModeBool: {
+            Page* page = m_parentFrame->page();
+            if (!page)
+                return NPERR_GENERIC_ERROR;
+            *((NPBool*)value) = !page->settings() || page->settings()->privateBrowsingEnabled();
+            return NPERR_NO_ERROR;
+        }
+
         default:
             return getValueStatic(variable, value);