Changeset 55513 in webkit


Ignore:
Timestamp:
Mar 4, 2010 1:24:45 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-03-04 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Adam Barth.

Fix incorrect setup of DateExtension.
​https://bugs.webkit.org/show_bug.cgi?id=35710

  • fast/dom/Window/resources/slow_unload_handler1.html:

2010-03-04 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Adam Barth.

Fix incorrect setup of DateExtension.
​https://bugs.webkit.org/show_bug.cgi?id=35710

  • bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep):
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r55511 r55513  
     12010-03-04  John Abd-El-Malek  <jam@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Fix incorrect setup of DateExtension.
     6        https://bugs.webkit.org/show_bug.cgi?id=35710
     7
     8        * fast/dom/Window/resources/slow_unload_handler1.html:
     9
    1102010-03-04  Oliver Hunt  <oliver@apple.com>
    211

  • trunk/LayoutTests/fast/dom/Window/resources/slow_unload_handler1.html

    r48612 r55513  
    11<html>
     2<head>
    23<script>
    3 function pause(milliseconds) {
     4window.addEventListener('unload', nopause1, false);
     5window.addEventListener('unload', nopause2, false);
     6window.addEventListener('unload', pause, false);
     7
     8function pause() {
    49    var now = new Date();
    5     var exitTime = now.getTime() + milliseconds;
     10    var exitTime = now.getTime() + 10000;
    611    while (true) {
    712        now = new Date();
    … …  
    1318        layoutTestController.notifyDone();
    1419}
     20
     21function nopause() {
     22    try {
     23        var time1 = (new Date()).getTime();
     24    } catch(e) {
     25        parent.document.getElementById("results").appendChild(document.createTextNode("FAIL"));
     26        if (layoutTestController)
     27            layoutTestController.notifyDone();
     28    }
     29}
     30function nopause1() {
     31    nopause();
     32}
     33
     34function nopause2() {
     35    nopause();
     36}
    1537</script>
    16 <body onunload="pause(10000);">
    17 </body>
     38</head>
     39<body></body>
    1840</html>

  • trunk/WebCore/ChangeLog

    r55511 r55513  
     12010-03-04  John Abd-El-Malek  <jam@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Fix incorrect setup of DateExtension.
     6        https://bugs.webkit.org/show_bug.cgi?id=35710
     7
     8        * bindings/v8/DateExtension.cpp:
     9        (WebCore::DateExtension::setAllowSleep):
     10
    1112010-03-04  Oliver Hunt  <oliver@apple.com>
    212

  • trunk/WebCore/bindings/v8/DateExtension.cpp

    r53965 r55513  
    8989
    9090    v8::Handle<v8::Value> argv[1];
    91     argv[0] = v8::String::New(allow ? "false" : "true");
     91    argv[0] = v8::Boolean::New(!allow);
    9292    v8::Handle<v8::Function>::Cast(sleepFunctionHandle)->Call(v8::Object::New(), 1, argv);
    9393}
Note: See TracChangeset for help on using the changeset viewer.