Changeset 55566 in webkit

Timestamp:

Mar 4, 2010 8:34:00 PM (14 years ago)

Author:

tony@chromium.org

Message:

2010-03-04 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=18819
Pressing option+page{down,up} should move the cursor and scroll in
content editable areas. On other platforms, pressing page{down,up}
should move the cursor and scroll in content editable areas.

• editing/input/option-page-up-down-expected.txt: Added.
• editing/input/option-page-up-down.html: Added.

2010-03-04 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=18819
Pressing option+page{down,up} should move the cursor and scroll in
content editable areas. On other platforms, pressing page{down,up}
should move the cursor and scroll in content editable areas.

Test: editing/input/option-page-up-down.html

• editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/input/option-page-up-down-expected.txt (added)
• LayoutTests/editing/input/option-page-up-down.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/editing/EditorCommand.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-03-04  Tony Chang  <tony@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        https://bugs.webkit.org/show_bug.cgi?id=18819
+        Pressing option+page{down,up} should move the cursor and scroll in
+        content editable areas.  On other platforms, pressing page{down,up}
+        should move the cursor and scroll in content editable areas.
+
+        * editing/input/option-page-up-down-expected.txt: Added.
+        * editing/input/option-page-up-down.html: Added.
+
 2010-03-03  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-04  Tony Chang  <tony@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        https://bugs.webkit.org/show_bug.cgi?id=18819
+        Pressing option+page{down,up} should move the cursor and scroll in
+        content editable areas.  On other platforms, pressing page{down,up}
+        should move the cursor and scroll in content editable areas.
+
+        Test: editing/input/option-page-up-down.html
+
+        * editing/EditorCommand.cpp:
+        (WebCore::verticalScrollDistance):
+
 2010-03-03  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/editing/EditorCommand.cpp

@@ -258 +258 @@
     if (!style)
         return 0;
-    if (!(style->overflowY() == OSCROLL || style->overflowY() == OAUTO || renderer->isTextArea()))
+    if (!(style->overflowY() == OSCROLL || style->overflowY() == OAUTO || focusedNode->isContentEditable()))
         return 0;
     int height = toRenderBox(renderer)->clientHeight();